Apply potion effects without adding onto current duration #2621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add replace existing effect
ShaneBeee
added
the
enhancement
bensku
requested changes
Dec 27, 2019
|
I made a few changes, and I believe it should be good now :) |
bensku
reviewed
Jan 10, 2020
| } | ||
| } | ||
| } | ||
| en.addPotionEffect(new PotionEffect(t, duration, a, ambient, particles), true); |
There was a problem hiding this comment.
Doesn't this prevent applying new effects altogether without using replace syntax?
There was a problem hiding this comment.
Looks like I missed this. It will not work it if replace syntax is not used and the user does not currently have that potion effect, so I will fix this soon.
bensku
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds in what is described in #2598. The syntax may be able to be improved and I'm open to any suggestions. I have not really made any changes in Skript's code before, so please let me know if I'm doing anything wrong :)
I built these changes and they worked perfectly when I tested them.
I was thinking we could also add in a test for the entire effect but I was not 100% sure on how to do it properly.
Target Minecraft Versions: Any
Requirements: None
Related Issues: #2598