apply effect fix

[3meraldK]

Description

fix an apply effect because it adds additional time for effect but it should set time

[bluelhf]

Do you mean that apply effect should be instant? AFAIK that's a spigot limitation, will look into it.

E: Looked into it. Doesn't look like you can make it instant.

[TPGamesNL]

Do you mean that apply effect should be instant? AFAIK that's a spigot limitation, will look into it.

E: Looked into it. Doesn't look like you can make it instant.

I think they mean that currently, when using the apply effect potion, it adds your chosen timespan to the duration of the effect (e.g. I already have 2 minutes of resistance, I use Skript to apply 1 minute, then I have 3 minutes of resistance). They probably don't want it to be added to the duration.

[bluelhf]

@TPGamesNL Could we not add a replacing existing effects part to the apply effect and remove the effect from the entity before adding it?

[TPGamesNL]

@TPGamesNL Could we not add a replacing existing effects part to the apply effect and remove the effect from the entity before adding it?

Yes that would probably be a good idea.
I just looked at the code for the effect, and apparently Skript does the adding of the duration manually: L35. But then they still make use of the force boolean...

[ShaneBeee]

Fixed in 2.5-alpha2