Migration update button component #10263

aveline · 2023-08-28T21:40:57Z

WHY are these changes introduced?

WHAT is this pull request doing?

Migration updates 920 files in web
Adds comments to 1650 files to be updated manually

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:

import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

Tested on mobile
Tested on multiple browsers
Tested for accessibility
Updated the component's README.md with documentation changes
Tophatted documentation changes in the style guide

Co-Authored-By: Lo Kim <26749317+laurkim@users.noreply.github.com>

Co-Authored-By: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>

aveline · 2023-08-31T17:49:12Z

/snapit

github-actions · 2023-08-31T17:53:05Z

🫰✨ Thanks @aveline! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20230831175131

yarn add @shopify/polaris@0.0.0-snapshot-release-20230831175131

kyledurand

This is looking great 🙌

.changeset/neat-balloons-shop.md

polaris-migrator/src/migrations/v12-react-update-button-components/transform.ts

Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>

Co-Authored-By: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>

aveline · 2023-09-06T17:20:04Z

/snapit

github-actions · 2023-09-06T17:25:10Z

🫰✨ Thanks @aveline! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20230906172306

yarn add @shopify/polaris@0.0.0-snapshot-release-20230906172306

Co-Authored-By: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>

aveline · 2023-09-06T19:42:38Z

/snapit

github-actions · 2023-09-06T19:46:38Z

🫰✨ Thanks @aveline! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20230906194504

yarn add @shopify/polaris@0.0.0-snapshot-release-20230906194504

@heyjoethomas

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@7.9.0 ### Minor Changes - [#9856](#9856) [`47652f7d6`](47652f7) Thanks [@heyjoethomas](https://github.com/heyjoethomas)! - Updates social media icons, removing them from their containers and adds a one for the Twitch platform. ## @shopify/polaris-migrator@0.22.0 ### Minor Changes - [#10263](#10263) [`67699cb88`](67699cb) Thanks [@aveline](https://github.com/aveline)! - Added migration for `Button` component ## @shopify/polaris@11.15.0 ### Minor Changes - [#9701](#9701) [`cbf539495`](cbf5394) Thanks [@martenbjork](https://github.com/martenbjork)! - Updated the Frame and Topbar components to stay clear of a scrollbar. This reduces the overall jumpiness in the UI when scrollbars appear and disappear when using a Polaris app. ### Patch Changes - [#10284](#10284) [`eba75d20a`](eba75d2) Thanks [@zakwarsame](https://github.com/zakwarsame)! - - Updated `Filters` query field to initialize with focus based on `mode` state - [#10282](#10282) [`9a2d4f62a`](9a2d4f6) Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed pointer alignment on tooltip - [#10343](#10343) [`12a62b4d7`](12a62b4) Thanks [@mrcthms](https://github.com/mrcthms)! - Fixed UI inconsistencies in the mobile view of the IndexFilters - [#10276](#10276) [`abb50250e`](abb5025) Thanks [@highfieldjames](https://github.com/highfieldjames)! - Updated `TextField` of `type` `number` to focus when a `Spinner` button is clicked - Updated dependencies \[[`47652f7d6`](47652f7)]: - @shopify/polaris-icons@7.9.0 ## polaris.shopify.com@0.57.3 ### Patch Changes - Updated dependencies \[[`47652f7d6`](47652f7), [`eba75d20a`](eba75d2), [`9a2d4f62a`](9a2d4f6), [`12a62b4d7`](12a62b4), [`cbf539495`](cbf5394), [`abb50250e`](abb5025)]: - @shopify/polaris-icons@7.9.0 - @shopify/polaris@11.15.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

### WHY are these changes introduced? Fixes Shopify#10161 ### WHAT is this pull request doing? Migration updates `920` files in `web` Adds comments to `1650` files to be updated manually ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)  <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Lo Kim <26749317+laurkim@users.noreply.github.com> Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>

aveline and others added 15 commits August 25, 2023 10:14

Add remove prop util

f279b63

scaffold out button migration

9df6b7b

Button migration remove prop

444cf5c

Handle button plain primary migration

793079e

Co-Authored-By: Lo Kim <26749317+laurkim@users.noreply.github.com>

Handle Button plain monochrome bools to variant

ae9ab66

Remove monochrome prop

f486b16

Update test cases

2df9a4c

Update test cases

947a8d3

Refactor migration

18478cf

Co-Authored-By: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>

Add more test cases

70bc289

Add tests for self-closing case

6645fee

Delete replace-bool-props-with-variant.ts

8e4fb07

Add comments

266d0c7

Clean up checks

782961b

Create neat-balloons-shop.md

41b6491

aveline requested review from kyledurand and aaronccasanova August 31, 2023 18:57

aveline marked this pull request as ready for review August 31, 2023 18:57

aveline changed the title ~~🚧 Migration update button component~~ Migration update button component Aug 31, 2023

kyledurand approved these changes Sep 5, 2023

View reviewed changes

Add check and test for local element name

43cd049

aaronccasanova reviewed Sep 6, 2023

View reviewed changes

aveline and others added 5 commits September 6, 2023 08:14

Update .changeset/neat-balloons-shop.md

01a7657

Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>

Rename migration to singular

b673ac7

Fix conditional check

4f78b26

Add check for spread sytax

35831f0

Add checks for Identifiers and ButtonProps

7a771dd

Co-Authored-By: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>

aaronccasanova approved these changes Sep 6, 2023

View reviewed changes

Add check to not capture children of MemberExpression

32352e9

Co-Authored-By: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>

aveline merged commit 67699cb into main Sep 6, 2023
10 checks passed

aveline deleted the migration-update-button-component branch September 6, 2023 20:36

shopify-github-actions-access bot mentioned this pull request Sep 6, 2023

Version Packages #10297

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migration update button component #10263

Migration update button component #10263

aveline commented Aug 28, 2023 •

edited

Loading

aveline commented Aug 31, 2023

github-actions bot commented Aug 31, 2023

kyledurand left a comment

aveline commented Sep 6, 2023

github-actions bot commented Sep 6, 2023

aveline commented Sep 6, 2023

github-actions bot commented Sep 6, 2023

Migration update button component #10263

Migration update button component #10263

Conversation

aveline commented Aug 28, 2023 • edited Loading

WHY are these changes introduced?

WHAT is this pull request doing?

How to 🎩

🎩 checklist

aveline commented Aug 31, 2023

github-actions bot commented Aug 31, 2023

kyledurand left a comment

Choose a reason for hiding this comment

aveline commented Sep 6, 2023

github-actions bot commented Sep 6, 2023

aveline commented Sep 6, 2023

github-actions bot commented Sep 6, 2023

aveline commented Aug 28, 2023 •

edited

Loading