feat: do not check whether optional type parameters of classes can be inferred #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1090 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 104 104
Lines 20595 20599 +4
Branches 4069 4069
=========================================
+ Hits 20595 20599 +4 ☔ View full report in Codecov by Sentry. |
lars-reimann
deleted the
1084-dont-check-whether-type-parameters-with-a-default-value-can-be-inferred
branch
lars-reimann
pushed a commit
that referenced
this pull request
Apr 24, 2024
## [0.13.0](v0.12.0...v0.13.0) (2024-04-24) ### Features * allow schemas in pipeline files ([#1080](#1080)) ([9508178](9508178)), closes [#1077](#1077) * annotations `@Category` and `@Tags` ([#1061](#1061)) ([e45a4c9](e45a4c9)), closes [#1021](#1021) * check if latest runner is installed ([#1097](#1097)) ([93432bb](93432bb)), closes [#1096](#1096) * do not check whether optional type parameters of classes can be inferred ([#1090](#1090)) ([31b8a28](31b8a28)), closes [#1084](#1084) [#1084](#1084) * generate nested functions for expression lambdas ([#1062](#1062)) ([f79fd61](f79fd61)) * mark schemas as experimental ([#1089](#1089)) ([09faaf0](09faaf0)), closes [#1078](#1078) * print values via code lens ([#1072](#1072)) ([f338023](f338023)), closes [#1032](#1032) * run pipeline via code lens ([#1068](#1068)) ([392154d](392154d)) * show image via code lens ([#1071](#1071)) ([bd0946b](bd0946b)), closes [#984](#984) ### Bug Fixes * import error when exploring tables in pipelines that call segments ([#1074](#1074)) ([e34b3ff](e34b3ff)) * pass optional arguments of memoized calls by name ([#1095](#1095)) ([39d9e5a](39d9e5a)), closes [#1087](#1087) * possible restart loop after installing the runner ([#1073](#1073)) ([7206d62](7206d62)) * runner not shutting down when extension was closed ([#1094](#1094)) ([77a0c1f](77a0c1f)) * stub for `Table.transformColumn` ([#1065](#1065)) ([aa43316](aa43316)) * type check arguments of annotation calls ([#1060](#1060)) ([09ca1cf](09ca1cf))
|
🎉 This PR is included in version 0.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1084
Summary of Changes
Optional type parameters of classes are now always allowed, even if they can never be inferred from their usage in the constructor.
This is useful to initialize them to some default value upon instantiation and override this value later, e.g. in return types of functions. See #1084 for an example.