Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import error when exploring tables in pipelines that call segments #1074

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

lars-reimann
Copy link
Member

Summary of Changes

Exploring a table in the following code

package bug

pipeline whoSurvived {
    val titanic = Table.fromCsvFile("titanic.csv");

    val beforeSplit = preprocessBeforeSplit(titanic);
}

segment preprocessBeforeSplit(table: Table) -> result: Table {
    yield result = table;
}

lead to a runtime error cannot import name 'preprocessBeforeSplit' from 'bug.gen_titanic' (unknown location).

The document that was created for profiling was not properly built, so an incorrect import was created for the segment, even though it was in the same document.

Copy link

github-actions bot commented Apr 22, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY git_diff yes no 0.12s
✅ TYPESCRIPT eslint 3 0 0 4.38s
✅ TYPESCRIPT prettier 3 0 0 0.9s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7206d62) to head (ef59e41).
Report is 95 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1074   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines        20560     20565    +5     
  Branches      4061      4061           
=========================================
+ Hits         20560     20565    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann marked this pull request as ready for review April 22, 2024 19:43
@lars-reimann lars-reimann merged commit e34b3ff into main Apr 22, 2024
7 checks passed
@lars-reimann lars-reimann deleted the fix-segments-eda branch April 22, 2024 19:43
lars-reimann pushed a commit that referenced this pull request Apr 24, 2024
## [0.13.0](v0.12.0...v0.13.0) (2024-04-24)

### Features

* allow schemas in pipeline files ([#1080](#1080)) ([9508178](9508178)), closes [#1077](#1077)
* annotations `@Category` and `@Tags` ([#1061](#1061)) ([e45a4c9](e45a4c9)), closes [#1021](#1021)
* check if latest runner is installed ([#1097](#1097)) ([93432bb](93432bb)), closes [#1096](#1096)
* do not check whether optional type parameters of classes can be inferred ([#1090](#1090)) ([31b8a28](31b8a28)), closes [#1084](#1084) [#1084](#1084)
* generate nested functions for expression lambdas ([#1062](#1062)) ([f79fd61](f79fd61))
* mark schemas as experimental ([#1089](#1089)) ([09faaf0](09faaf0)), closes [#1078](#1078)
* print values via code lens ([#1072](#1072)) ([f338023](f338023)), closes [#1032](#1032)
* run pipeline via code lens ([#1068](#1068)) ([392154d](392154d))
* show image via code lens ([#1071](#1071)) ([bd0946b](bd0946b)), closes [#984](#984)

### Bug Fixes

* import error when exploring tables in pipelines that call segments ([#1074](#1074)) ([e34b3ff](e34b3ff))
* pass optional arguments of memoized calls by name ([#1095](#1095)) ([39d9e5a](39d9e5a)), closes [#1087](#1087)
* possible restart loop after installing the runner ([#1073](#1073)) ([7206d62](7206d62))
* runner not shutting down when extension was closed ([#1094](#1094)) ([77a0c1f](77a0c1f))
* stub for `Table.transformColumn` ([#1065](#1065)) ([aa43316](aa43316))
* type check arguments of annotation calls ([#1060](#1060)) ([09ca1cf](09ca1cf))
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant