Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate nested functions for expression lambdas #1062

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Apr 18, 2024

Summary of Changes

For expression lambdas, we now also generate nested functions instead of Python lambdas. This is

  1. more readable,
  2. better for memoization, since we use the source code of a callable for lookup and Python is not able to return only the source code of a lambda.

Copy link

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY git_diff yes no 0.07s
✅ TYPESCRIPT eslint 1 0 0 4.28s
✅ TYPESCRIPT prettier 1 0 0 1.05s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e45a4c9) to head (d599fb1).
Report is 105 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1062   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           99        99           
  Lines        19586     19604   +18     
  Branches      4004      4009    +5     
=========================================
+ Hits         19586     19604   +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann marked this pull request as ready for review April 18, 2024 17:07
@lars-reimann lars-reimann merged commit f79fd61 into main Apr 18, 2024
8 checks passed
@lars-reimann lars-reimann deleted the expression-lambda-codegen branch April 18, 2024 17:07
lars-reimann pushed a commit that referenced this pull request Apr 24, 2024
## [0.13.0](v0.12.0...v0.13.0) (2024-04-24)

### Features

* allow schemas in pipeline files ([#1080](#1080)) ([9508178](9508178)), closes [#1077](#1077)
* annotations `@Category` and `@Tags` ([#1061](#1061)) ([e45a4c9](e45a4c9)), closes [#1021](#1021)
* check if latest runner is installed ([#1097](#1097)) ([93432bb](93432bb)), closes [#1096](#1096)
* do not check whether optional type parameters of classes can be inferred ([#1090](#1090)) ([31b8a28](31b8a28)), closes [#1084](#1084) [#1084](#1084)
* generate nested functions for expression lambdas ([#1062](#1062)) ([f79fd61](f79fd61))
* mark schemas as experimental ([#1089](#1089)) ([09faaf0](09faaf0)), closes [#1078](#1078)
* print values via code lens ([#1072](#1072)) ([f338023](f338023)), closes [#1032](#1032)
* run pipeline via code lens ([#1068](#1068)) ([392154d](392154d))
* show image via code lens ([#1071](#1071)) ([bd0946b](bd0946b)), closes [#984](#984)

### Bug Fixes

* import error when exploring tables in pipelines that call segments ([#1074](#1074)) ([e34b3ff](e34b3ff))
* pass optional arguments of memoized calls by name ([#1095](#1095)) ([39d9e5a](39d9e5a)), closes [#1087](#1087)
* possible restart loop after installing the runner ([#1073](#1073)) ([7206d62](7206d62))
* runner not shutting down when extension was closed ([#1094](#1094)) ([77a0c1f](77a0c1f))
* stub for `Table.transformColumn` ([#1065](#1065)) ([aa43316](aa43316))
* type check arguments of annotation calls ([#1060](#1060)) ([09ca1cf](09ca1cf))
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant