Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated MacOSX workflow with caching #1238

Closed
wants to merge 1 commit into from
Closed

Updated MacOSX workflow with caching #1238

wants to merge 1 commit into from

Conversation

simonsan
Copy link
Contributor

@simonsan simonsan commented Apr 26, 2020 •
edited
Loading

Should be much faster now. And it builds with clang++ and ccache. 👍

ref.: #1196

@simonsan simonsan added os: macos macOS-specific issue area: buildsystem Related to our cmake/python buildsystem ci Related to our continuous integration systems (kevin, github-actions, ...) labels Apr 26, 2020
@simonsan simonsan force-pushed the update-macosx-workflow branch 3 times, most recently from b13a1e9 to 3995c82 Compare April 26, 2020 20:19
@simonsan simonsan removed the area: buildsystem Related to our cmake/python buildsystem label Apr 27, 2020
@simonsan simonsan force-pushed the update-macosx-workflow branch 12 times, most recently from f073a5e to 3d1f79e Compare April 30, 2020 00:41
@goto-bus-stop
Copy link
Contributor

I don't think I'll be able to look closely at these PRs in the near future, sorry :(

@goto-bus-stop goto-bus-stop removed their request for review April 30, 2020 15:03
@simonsan
Copy link
Contributor Author

I don't think I'll be able to look closely at these PRs in the near future, sorry :(

Ok, no problem. ;-)

TheJJ
TheJJ previously approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@TheJJ TheJJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks very verbose and complicated, but if this is what it takes to have fast caching with github-ci... well.

README.md Outdated Show resolved Hide resolved
.github/workflows-support/requirements.txt Outdated Show resolved Hide resolved
@simonsan
Copy link
Contributor Author

simonsan commented May 4, 2020

this looks very verbose and complicated, but if this is what it takes to have fast caching with github-ci... well.

Unfortunately yes, we just have 5 GB of cache there and we want to cache the brew stuff so i used zstd to compress and purge most of the brew packages. XD

simonsan
simonsan commented May 4, 2020
View reviewed changes
Copy link
Contributor Author

@simonsan simonsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now should be fine, rebased it.

@simonsan
Copy link
Contributor Author

simonsan commented May 8, 2020

@TheJJ rebased

@simonsan
Copy link
Contributor Author

@TheJJ LGTM :-)

@simonsan simonsan requested a review from TheJJ May 12, 2020 07:45
@simonsan simonsan mentioned this pull request Aug 26, 2020
Merged
janisozaur
janisozaur reviewed Aug 26, 2020
View reviewed changes
.github/workflows/macosx-ci.yml
on: [push, pull_request]
env:
QT_INSTALL_VERSION: '5.14.2' # This version we need to set, because we don't want 5.12.x LTS
CCACHE_COMPRESS: 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very wise

.github/workflows/macosx-ci.yml
- name: Build
run: make
run: make build -j"$(sysctl -n hw.physicalcpu || echo 4)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better use ninja

@simonsan
Copy link
Contributor Author

(Outdated)

@simonsan simonsan closed this Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janisozaur janisozaur janisozaur left review comments

@TheJJ TheJJ Awaiting requested review from TheJJ

Assignees
No one assigned
Labels
ci Related to our continuous integration systems (kevin, github-actions, ...) os: macos macOS-specific issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simonsan @goto-bus-stop @janisozaur @TheJJ