-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Umbrella] Adding Github workflows #1196
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonsan
added
os: windows
Windows-specific issue
os: linux
Linux-specific issue
documentation
Involves the project documentation
ci
Related to our continuous integration systems (kevin, github-actions, ...)
labels
Nov 20, 2019
simonsan
commented
Nov 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some thoughts:
6 tasks
simonsan
changed the title
[WIP] Adding Github workflows for Win + Fallback/CI for forks on Ubuntu
Adding Github workflows for Win + Fallback/CI for forks on Ubuntu
Nov 20, 2019
simonsan
changed the title
Adding Github workflows for Win + Fallback/CI for forks on Ubuntu
[WIP] Adding Github workflows for Win + Fallback/CI for forks on Ubuntu
Nov 20, 2019
simonsan
force-pushed
the
github-workflows
branch
19 times, most recently
from
November 20, 2019 20:26
00847be
to
357f838
Compare
simonsan
force-pushed
the
github-workflows
branch
13 times, most recently
from
November 23, 2019 17:59
f4f4320
to
07a3e96
Compare
simonsan
force-pushed
the
github-workflows
branch
2 times, most recently
from
November 29, 2019 19:48
63bdb22
to
080076a
Compare
Cache limit for workflows got increased, so we probably could cache the complete Qt and vcpkg dir to make build times smaller.
|
This was referenced Apr 26, 2020
simonsan
force-pushed
the
github-workflows
branch
2 times, most recently
from
April 30, 2020 00:03
2d6a62d
to
532cf13
Compare
simonsan
force-pushed
the
github-workflows
branch
from
April 30, 2020 00:08
532cf13
to
92a88ea
Compare
(Outdated) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci
Related to our continuous integration systems (kevin, github-actions, ...)
documentation
Involves the project documentation
os: linux
Linux-specific issue
os: macos
macOS-specific issue
os: windows
Windows-specific issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ci: adding windows and ubuntu workflows,
doc: adding status badges for mac and win to readme.md
For the caching there is still some fine-tuning needed in the future. I'm also waiting for an increase of the limit and possibility to cache
vcpkg/installed
-dir of github-actions (actions/cache#6) and adding vcpkg packages to the virtual env (actions/runner-images#11) and that Qt gets added to the images (actions/runner-images#8). That overall could lower the win build for around 12 minutes.The Ubuntu-CI is not running inside this main repo, but just outside for any forks of openage. People can make future use of this for pre-diagnosing
clang-tidy
-errors orclang-format
-stuff inside their forked repositories. This functionality (clang-tidy and clang-format) is not added with this PR though and might come in the future.Win
install prefix
on x64 target beingprogram files (x86)
=> Around this function (thanks tu) (can't reproduce for now, later?)Win-MSYS2
Linux
make
targetsIdeas:
Mac
fonts
problem