Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-link): fix "click twice" issue in Safari (#1799) #1800

Merged
merged 2 commits into from
Jun 15, 2020

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Jun 15, 2020

The usage of pseudo elements such as ::after, ::before has side effects on iOs/macOS making the first click to just focus the element and the second to be registered as click. Now, we set the focus with outline, instead of pseudo element. Note: in IE, the focus will be 1px wider on all sides, compared to Safari, Chrome and FF as the outline-offset is not supported.

FIXES: #1796

fifoosid
fifoosid previously approved these changes Jun 15, 2020
Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should then delete the CSS Var that is no longer used

@ilhan007 ilhan007 requested a review from vladitasev June 15, 2020 12:50
@ilhan007 ilhan007 merged commit 0f69b84 into master Jun 15, 2020
@ilhan007 ilhan007 deleted the fix-link-safari branch June 15, 2020 14:26
ilhan007 added a commit that referenced this pull request Jun 15, 2020
The usage of pseudo elements such as ::after, ::before has side effects on iOs/macOS making the first click to just focus the element and the second to be registered as click. Now, we set the focus with outline, instead of pseudo element. Note: in IE, the focus will be 1px wider on all sides, compared to Safari, Chrome and FF as the outline-offset is not supported.

FIXES: #1796
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui5-link need to be clicked twice to trigger event in Safari
3 participants