Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-link need to be clicked twice to trigger event in Safari #1796

Closed
GongRichard opened this issue Jun 15, 2020 · 0 comments · Fixed by #1800
Closed

ui5-link need to be clicked twice to trigger event in Safari #1796

GongRichard opened this issue Jun 15, 2020 · 0 comments · Fixed by #1800
Assignees
@ilhan007
Labels
SAP SF

Comments

@GongRichard
Copy link

Describe the bug
ui5-link need to be clicked twice to trigger event in Safari

To reproduce
Steps to reproduce the behavior:

  1. Use Safari to open https://github.wdf.sap.corp/pages/xweb/goalmanagementx/app.html?mock#/goal-detail
  2. Click top breadcrumb link, and you need to click it twice then nav to another page.
    2020-06-15_15-34-06

Context

  • UI5 Web Components version 1.0.0-rc7
  • OS/Platform: {macos}
  • Browser (if relevant): {Safari}
  • Other information: {...}
@ilhan007 ilhan007 self-assigned this Jun 15, 2020
@ilhan007 ilhan007 mentioned this issue Jun 15, 2020
Merged
ilhan007 added a commit that referenced this issue Jun 15, 2020
@ilhan007
fix(ui5-link): fix "click twice" issue in Safari (#1799) (#1800)
0f69b84 
The usage of pseudo elements such as ::after, ::before has side effects on iOs/macOS making the first click to just focus the element and the second to be registered as click. Now, we set the focus with outline, instead of pseudo element. Note: in IE, the focus will be 1px wider on all sides, compared to Safari, Chrome and FF as the outline-offset is not supported.

FIXES: #1796
ilhan007 added a commit that referenced this issue Jun 15, 2020
@ilhan007
fix(ui5-link): fix "click twice" issue in Safari (#1799) (#1800)
16987eb 
The usage of pseudo elements such as ::after, ::before has side effects on iOs/macOS making the first click to just focus the element and the second to be registered as click. Now, we set the focus with outline, instead of pseudo element. Note: in IE, the focus will be 1px wider on all sides, compared to Safari, Chrome and FF as the outline-offset is not supported.

FIXES: #1796
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilhan007 ilhan007

Labels
SAP SF
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-link): fix "click twice" issue in Safari (#1799) SAP/ui5-webcomponents
2 participants
@GongRichard @ilhan007