Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Find It! code #140

Closed
RocketMan opened this issue Feb 14, 2020 · 0 comments · Fixed by #142
Closed

Refactor Find It! code #140

RocketMan opened this issue Feb 14, 2020 · 0 comments · Fixed by #142
Assignees
@RocketMan
Labels
enhancement New feature or request
Milestone
v2.8.0

Comments

@RocketMan
Copy link
Owner

Refactor the inline js Find It! code to external. At the same time, migrate from DOM to jQuery.

The refactored code will use the JSON API rather than XML.

No change in functionality is anticipated; the objective is to improve readability and maintainability.

Testing: Ensure there are no regressions; behaviour should be identical to pre-refactored code.
@RocketMan RocketMan added the enhancement New feature or request label Feb 14, 2020
@RocketMan RocketMan self-assigned this Feb 14, 2020
RocketMan added a commit that referenced this issue Feb 14, 2020
@RocketMan
migrated Find It! to json/jQuery
a26d5a9 
fixes #140
RocketMan added a commit that referenced this issue Feb 14, 2020
@RocketMan
migrated Find It! to json/jQuery
94e5219 
fixes #140
@RocketMan RocketMan added this to the v2.8.0 milestone Feb 15, 2020
@RocketMan RocketMan mentioned this issue Feb 15, 2020
Merged
@RocketMan RocketMan mentioned this issue Mar 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RocketMan RocketMan

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.8.0
Development

Successfully merging a pull request may close this issue.

Find It! cleanup RocketMan/zookeeper
1 participant
@RocketMan