Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block scoping causing problems in older browsers #146

Closed
RocketMan opened this issue Mar 5, 2020 · 1 comment
Closed

Block scoping causing problems in older browsers #146

RocketMan opened this issue Mar 5, 2020 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@RocketMan
Copy link
Owner

The changes introduced by #140 adversely affect browsers which do not yet support javascript block scoping that was introduced in ECMAScript2015.

For example, an older version of Chrome gives this error when using FindIt!
Uncaught SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode

@RocketMan RocketMan added the bug Something isn't working label Mar 5, 2020
@RocketMan RocketMan added this to the v2.8.1 milestone Mar 5, 2020
@RocketMan RocketMan self-assigned this Mar 5, 2020
@RocketMan
Copy link
Owner Author

commit b4361f8 replaces block scoping with higher-order functions to implement closure; the latter should be supported even in older browsers

Patch landed hotfix-2-8-0, prod; closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant