Adding an ES6 only branch #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will hopefully make situations like RobotWebTools#209 easier to debug
…g. 1 - removed explicit super.super() call from InteractiveMarker. 2 - Made Particles explicitly derive from THREE.Object3D.
…ed a relevant comment
…module extensions
…l imports in browsers
… for es6 transpiled output
* buffergeometry in PointCloud2 * pointcloud2: buffergeometry, subsampling * renamed Particles.js to Points.js, deprecation warning in Points.js * Update kitti.html * Removing redundant roslaunch calls in the help.
- This is a no-op to simplify future merges
- This pulls in changes from PRs RobotWebTools#207, RobotWebTools#210, RobotWebTools#218, RobotWebTools#221, and RobotWebTools#223 - Note: src/sensors/Points.js was modified to *explicitly* extend THREE.Object3D to support transpiling
- This pulls in changes from PRs RobotWebTools#207, RobotWebTools#210, RobotWebTools#218, RobotWebTools#221, and RobotWebTools#223 - Note: src/sensors/Points.js was modified to *explicitly* extend THREE.Object3D to support transpiling
- Updated outdated grunt plugins - Updated grunt build process to build es6 output
- Switched from jshint to eslint, migrating rules and fixing lint issues
- Updated commonjs target to be es5
- Fixed pkg.module to use es6 module syntax, but es5 language features
- Switched from const to var for es5 compatibility - Fixed bug in Points class
- Added PointCloud2 example for angular app
- Updated node version use by CI server
This was referenced Jul 4, 2018
Merged
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a larger movement to move this codebase to be entirely ES6 (#228).
Specifically, this PR will bring
develop-es6up to parity withdevelop, part of step 2: