fix: pointRatio option in PointCloud2 and LaserScan #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, that works now, I'm attaching a screenshot.. thanks I already closed #217
|
jihoonl
approved these changes
Apr 17, 2018
|
Thanks for the quick fix. |
keego
added a commit
to keego/ros3djs
that referenced
this pull request
Apr 29, 2018
- This pulls in changes from PRs RobotWebTools#207, RobotWebTools#210, RobotWebTools#218, RobotWebTools#221, and RobotWebTools#223 - Note: src/sensors/Points.js was modified to *explicitly* extend THREE.Object3D to support transpiling
keego
added a commit
to keego/ros3djs
that referenced
this pull request
Apr 29, 2018
- This pulls in changes from PRs RobotWebTools#207, RobotWebTools#210, RobotWebTools#218, RobotWebTools#221, and RobotWebTools#223 - Note: src/sensors/Points.js was modified to *explicitly* extend THREE.Object3D to support transpiling
keego
added a commit
to keego/ros3djs
that referenced
this pull request
Apr 30, 2018
- This pulls in changes from PRs RobotWebTools#207, RobotWebTools#210, RobotWebTools#218, RobotWebTools#221, and RobotWebTools#223 - Note: src/sensors/Points.js was modified to *explicitly* extend THREE.Object3D to support transpiling
keego
added a commit
to keego/ros3djs
that referenced
this pull request
Apr 30, 2018
- This pulls in changes from PRs RobotWebTools#207, RobotWebTools#210, RobotWebTools#218, RobotWebTools#221, and RobotWebTools#223 - Note: src/sensors/Points.js was modified to *explicitly* extend THREE.Object3D to support transpiling
keego
added a commit
to keego/ros3djs
that referenced
this pull request
May 1, 2018
- This pulls in changes from PRs RobotWebTools#207, RobotWebTools#210, RobotWebTools#218, RobotWebTools#221, and RobotWebTools#223 - Note: src/sensors/Points.js was modified to *explicitly* extend THREE.Object3D to support transpiling
jihoonl
pushed a commit
that referenced
this pull request
Aug 24, 2018
* Fix links in example and readme (#206) * Report error from ColladaLoader in MeshResource (#210) this will hopefully make situations like #209 easier to debug * Added Rollup * Added yarn lockfile * Removed references to COLLADA_LOADER_2 * Added es6 transpiler and rollup config, working on transpiling * Touched up a couple potential mistypes prevent transpiler from working. 1 - removed explicit super.super() call from InteractiveMarker. 2 - Made Particles explicitly derive from THREE.Object3D. * Rewrote Particles' method signatures in format consistent with rest of codebase * Refactored updateMatrixWorld to be more statically analyzable * ES6 modules properly compiling, Working on runtime errors * Moved 'that' assignments happen *after* calls super constructors in derived classes * Added missing super constructor call * Removed assignment to read-only property causing a runtime error, added a relevant comment * Moved all super constructor calls to preceed any use of 'this' * Added shims for THREE and THREE extensions to support es6 compatible module extensions * Cleanup and added examples for single page applications and using html imports in browsers * Moved es6 support files to es6-support folder and renamed destination for es6 transpiled output * Moved shims to top level * Removed pre-es6 source code and es6 transpiler * DepthCloud: make depth range adaptable + fix depth point position decoding (#207) * PointCloud2 and LaserScan (#218) * buffergeometry in PointCloud2 * pointcloud2: buffergeometry, subsampling * renamed Particles.js to Points.js, deprecation warning in Points.js * Update kitti.html * Removing redundant roslaunch calls in the help. * NavSatFix support (#221) * fix: pointRatio option in PointCloud2 and LaserScan (#223) * Added build products * Removed extra log * Added angular app example * Added react app example and touched up other SPA examples * Added build output * Removed extra log * Added angular app example * Added react app example and touched up other SPA examples * Updated ROSLIB import semantics * Updated ROSLIB import semantics * Switched ColladaLoader shim from official ColladaLoader to the ros3djs fork * Switched ColladaLoader shim from official ColladaLoader to the ros3djs fork * Updated html-import example to use yarn like the other examples * Updated html-import example to use yarn like the other examples * Updated outdated grunt plugins * Fixed linter errors * Updated grunt build process to build es6 output * Switched from jshint to eslint, migrating rules and fixing lint issues * Updated commonjs target to be es5 * Fixed pkg.module to use es6 module syntax, but es5 language features * Fixed bug in Points class * Switched from const to var for es5 compatibility * Added PointCloud2 example for angular app * Updated node version use by CI server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the pointRatio option (introduced in #218) of PointCloud2 and LaserScan (bug reported in #217)