Optimize rule/marginalrule dispatch #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #299 +/- ##
==========================================
+ Coverage 62.57% 64.32% +1.74%
==========================================
Files 197 197
Lines 7394 7363 -31
==========================================
+ Hits 4627 4736 +109
+ Misses 2767 2627 -140
... and 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
albertpod
approved these changes
Mar 23, 2023
|
Thanks for fixing the docs @bartvanerp . Are you okay with the remaining changes? Or did you plan to change text in other places? |
bartvanerp
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves upon #290 and addresses #284 even further.
A better version of the #292 without breaking changes. The PR improves execution time and memory allocation profile in 100% test-cases by various degree. Particularly useful for small models and real-time inference at a high rate, but also improves the performance of variational iterations.
Timings
Memory profile
This PR also removes the
@symmetricalmacro (was unused really) and removes options from therulemacro (was unused too).EDIT: This PR also adds documentation/docstrings for the
@rule,@call_rule,@marginalruleand@call_marginalrule.