Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(): improve allocation profile for rule dispatching #290

Merged
merged 1 commit into from
Mar 3, 2023
Merged

chore(): improve allocation profile for rule dispatching #290

merged 1 commit into from
Mar 3, 2023

Conversation

bvdmitri
Copy link
Member

@bvdmitri bvdmitri commented Mar 2, 2023

This PR fixes #284.

@bvdmitri bvdmitri requested a review from albertpod March 2, 2023 16:12
@bvdmitri
Copy link
Member Author

bvdmitri commented Mar 2, 2023

The allocation profile in the TinyBenchmark.ipynb from RxInfer:

master

Memory estimate: 3.45 MiB, allocs estimate: 85342.
Memory estimate: 12.56 MiB, allocs estimate: 247416.

This PR:

Memory estimate: 3.03 MiB, allocs estimate: 83328.
Memory estimate: 11.10 MiB, allocs estimate: 241913.

@albertpod
Copy link
Member

I like the improvement. Looks elegant. I will wait for the tests locally and approve once it's green :)

albertpod
albertpod approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@albertpod albertpod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests are passing. Ready to merge.

@bvdmitri bvdmitri merged commit 79b86ce into master Mar 3, 2023
@bvdmitri bvdmitri deleted the fix-allocs-rule-node branch March 3, 2023 11:08
@bvdmitri bvdmitri mentioned this pull request Mar 3, 2023
Closed
@bvdmitri bvdmitri mentioned this pull request Mar 22, 2023
Merged
@bvdmitri bvdmitri mentioned this pull request Apr 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertpod albertpod albertpod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Excessive/unnecessary allocations in the call_rule_make_node and MessageMapping
2 participants
@bvdmitri @albertpod