Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: qwik-prefetch-worker #5618

Merged
merged 31 commits into from
Jan 8, 2024
Merged

feat: qwik-prefetch-worker #5618

merged 31 commits into from
Jan 8, 2024

Conversation

mhevery
Copy link
Contributor

@mhevery mhevery commented Dec 21, 2023

New implementation of SW (Service Worker)

Issues with old implementation:

  • Part of Qwik-city therefore it can be used in qwik-only solutions such as Astro
  • Only one SW can be per page. If MFE (micro frontends) than we can't prefetch each MFE

How to use

  1. Include a single <PrefetchServiceWorker /> somewhere on the page. This is usually in root.tsx but can be a different place, especially if MFE.
  2. For each MFE include <PrefetchGraph />

Example of what a simple application may look like:

      <head>
        ...
        <PrefetchServiceWorker />
        <PrefetchGraph />
      </head>

That is it! Happy coding.

Copy link

netlify bot commented Dec 21, 2023

Deploy Preview for qwik-insights ready!

Name Link
🔨 Latest commit f1127a9
🔍 Latest deploy log https://app.netlify.com/sites/qwik-insights/deploys/6595beccc0f0e40008eac08d
😎 Deploy Preview https://deploy-preview-5618--qwik-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cloudflare-workers-and-pages bot commented Dec 21, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f1127a9
Status: ✅  Deploy successful!
Preview URL: https://7e340d69.qwik-docs.pages.dev
Branch Preview URL: https://build-sw-refactor.qwik-docs.pages.dev

View logs

@thejackshelton thejackshelton changed the title WIP: qwik-prefetch-worker qwik-prefetch-worker Dec 29, 2023
@thejackshelton thejackshelton changed the title qwik-prefetch-worker feat: qwik-prefetch-worker Dec 29, 2023
@mhevery mhevery merged commit 0f0c76b into main Jan 8, 2024
45 checks passed
@mhevery mhevery deleted the build/sw-refactor branch January 8, 2024 19:32
kodiakhq bot pushed a commit to ascorbic/unpic-img that referenced this pull request Jan 30, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@builder.io/qwik](https://qwik.builder.io/) ([source](https://github.com/BuilderIO/qwik/tree/HEAD/packages/qwik)) | [`1.3.2` -> `1.4.3`](https://renovatebot.com/diffs/npm/@builder.io%2fqwik/1.3.2/1.4.3) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@builder.io%2fqwik/1.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@builder.io%2fqwik/1.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@builder.io%2fqwik/1.3.2/1.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@builder.io%2fqwik/1.3.2/1.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>BuilderIO/qwik (@&#8203;builder.io/qwik)</summary>

### [`v1.4.3`](https://github.com/BuilderIO/qwik/releases/tag/v1.4.3)

[Compare Source](https://github.com/BuilderIO/qwik/compare/v1.4.2...v1.4.3)

#### What's Changed

-   chore(vite): downgrade vite version by [@&#8203;balaji-sivasakthi](https://github.com/balaji-sivasakthi) in [QwikDev/qwik#5785
-   fix(starter): adjust padding for 768px devices by [@&#8203;balaji-sivasakthi](https://github.com/balaji-sivasakthi) in [QwikDev/qwik#5787
-   chore: lint++ by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5788
-   fix(qwik-city): fix import ./[@&#8203;qwik-city](https://github.com/qwik-city) files in prod by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5791
-   fix(qwik-auth): lock down `@auth/core` version by [@&#8203;balazsorban44](https://github.com/balazsorban44) in [QwikDev/qwik#5790
-   chore(docs): align indentation by [@&#8203;greatgraphicdesign](https://github.com/greatgraphicdesign) in [QwikDev/qwik#5792
-   chore(docs): Update to latest builder.io/sdk-qwik by [@&#8203;STRd6](https://github.com/STRd6) in [QwikDev/qwik#5794
-   docs: Redirect all requests from builder.io to the qwik.dev domain. by [@&#8203;mhevery](https://github.com/mhevery) in [QwikDev/qwik#5796
-   feat(QwikCityMockProvider): add optional goto prop by [@&#8203;alexismch](https://github.com/alexismch) in [QwikDev/qwik#5779
-   chore(starters): update 🐼 PandaCSS integration starter dev dependency by [@&#8203;mrhoodz](https://github.com/mrhoodz) in [QwikDev/qwik#5797
-   feat(qwik): configure sourcemap in optimizer by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5799
-   chore: 1.4.3 by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5800

#### New Contributors

-   [@&#8203;balaji-sivasakthi](https://github.com/balaji-sivasakthi) made their first contribution in [QwikDev/qwik#5785
-   [@&#8203;balazsorban44](https://github.com/balazsorban44) made their first contribution in [QwikDev/qwik#5790
-   [@&#8203;greatgraphicdesign](https://github.com/greatgraphicdesign) made their first contribution in [QwikDev/qwik#5792
-   [@&#8203;alexismch](https://github.com/alexismch) made their first contribution in [QwikDev/qwik#5779

**Full Changelog**: QwikDev/qwik@v1.4.2...v1.4.3

### [`v1.4.2`](https://github.com/BuilderIO/qwik/releases/tag/v1.4.2)

[Compare Source](https://github.com/BuilderIO/qwik/compare/v1.4.1...v1.4.2)

##### What's Changed

-   fix(docs): Sandbox playground iframe by [@&#8203;STRd6](https://github.com/STRd6) in [QwikDev/qwik#5768
-   docs(astro): update integration doc by [@&#8203;thejackshelton](https://github.com/thejackshelton) in [QwikDev/qwik#5771
-   docs: add note about Astro integrations order importance by [@&#8203;Seanmclem](https://github.com/Seanmclem) in [QwikDev/qwik#5776
-   feat(dev): preload modules for / so dev starts faster by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5775
-   fix: SW cache race condition by [@&#8203;thejackshelton](https://github.com/thejackshelton) in [QwikDev/qwik#5780
-   chore: 1.4.2 by [@&#8203;thejackshelton](https://github.com/thejackshelton) in [QwikDev/qwik#5781

##### New Contributors

-   [@&#8203;Seanmclem](https://github.com/Seanmclem) made their first contribution in [QwikDev/qwik#5776

**Full Changelog**: QwikDev/qwik@v1.4.1...v1.4.2

### [`v1.4.1`](https://github.com/BuilderIO/qwik/releases/tag/v1.4.1)

[Compare Source](https://github.com/BuilderIO/qwik/compare/v1.4.0...v1.4.1)

##### Overview

-   Try harder to prevent dirty tasks on SSR
-   AWS middleware in `qwik-city`
-   File filter option to make Qwik work better with Astro
-   `qwik-auth` can now handle multiple cookies
-   Node adapters in `qwik-city` now read .env files
-   Bugfixes in various service workers, starter CSS build, etc
-   Dependency updates

Thanks to all contributors!

##### Commits

-   chore(starters): update 🐼 PandaCSS integration dev dependency  by [@&#8203;mrhoodz](https://github.com/mrhoodz) in [QwikDev/qwik#5739
-   docs: add Valibot website to showcases by [@&#8203;fabian-hiller](https://github.com/fabian-hiller) in [QwikDev/qwik#5740
-   fix: multiple cookies in qwik-auth by [@&#8203;ksjogo](https://github.com/ksjogo) in [QwikDev/qwik#5602
-   feat(qwik-city): AWS adapter middleware by [@&#8203;leifermendez](https://github.com/leifermendez) in [QwikDev/qwik#5732
-   docs: fix code highlight by downgrading rehype-pretty-code by [@&#8203;Balastrong](https://github.com/Balastrong) in [QwikDev/qwik#5742
-   feat(starters): add dotenv in node adapters by [@&#8203;hassanzohdy](https://github.com/hassanzohdy) in [QwikDev/qwik#5749
-   fix(docs): Validate origin on postmessage by [@&#8203;STRd6](https://github.com/STRd6) in [QwikDev/qwik#5751
-   feat(vite): new file filter option by [@&#8203;thejackshelton](https://github.com/thejackshelton) in [QwikDev/qwik#5752
-   fix(ssr): dirty tasks by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5741
-   fix(qwik): ensure that SW cache is properly opened by [@&#8203;mhevery](https://github.com/mhevery) in [QwikDev/qwik#5748
-   fix: insights error handling and qwik-city json imports by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5754
-   fix(prefetch-sw): await cache opening by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5759
-   chore: updates by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5760
-   fix(sw-prefetch): prevent uninitialized cache use by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5761
-   fix(sw-prefetch): cache handling by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5764
-   fix: duplicated css code in global.css in starter template by [@&#8203;linkfang](https://github.com/linkfang) in [QwikDev/qwik#5763
-   feat(repl): use bundled qwik and prettier versions by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5755
-   fix(sw-prefetch): clone on reuse by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5765
-   chore: 1.4.1 by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5766

##### New Contributors

-   [@&#8203;STRd6](https://github.com/STRd6) made their first contribution in [QwikDev/qwik#5751

**Full Changelog**: QwikDev/qwik@v1.4.0...v1.4.1

### [`v1.4.0`](https://github.com/BuilderIO/qwik/releases/tag/v1.4.0)

[Compare Source](https://github.com/BuilderIO/qwik/compare/v1.3.5...v1.4.0)

##### What's Changed

-   Types have changed a bit, now JSX components output `JSXOutput` instead of `JSXNode`, which captures the existing possibility to return strings, booleans, arrays etc.
-   The Link component now automatically prefetches the JS needed
-   When SPA routing fails, it will now use MPA routing as a fallback
-   Various bugfixes

##### PRs merged

-   docs(showcase): add Blueagle's Profolio & Blog by [@&#8203;blueagler](https://github.com/blueagler) in [QwikDev/qwik#5695
-   docs(showcase): update metrics by [@&#8203;gioboa](https://github.com/gioboa) in [QwikDev/qwik#5707
-   fix(types): untyped components, test more edge cases by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5713
-   docs(showcase): add Zhou's portfolio by [@&#8203;linkfang](https://github.com/linkfang) in [QwikDev/qwik#5710
-   chore: upgrades by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5705
-   fix(qwik): register new index.d.ts package file by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5715
-   docs: move props example after local state and useStore explanation by [@&#8203;Balastrong](https://github.com/Balastrong) in [QwikDev/qwik#5718
-   docs: emphasize on useStore and onInput$ by [@&#8203;Balastrong](https://github.com/Balastrong) in [QwikDev/qwik#5719
-   docs: add Storybook Examples by [@&#8203;thenhawke](https://github.com/thenhawke) in [QwikDev/qwik#5720
-   fix(jsx-qwik-attributes): fix ts error TS4023 by [@&#8203;maiieul](https://github.com/maiieul) in [QwikDev/qwik#5722
-   fix(types): JSX.Element is JSXOutput by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5723
-   fix: prevent race condition by [@&#8203;mhevery](https://github.com/mhevery) in [QwikDev/qwik#5711
-   fix: build from scratch + insights by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5724
-   docs: Good first issue link doesn't lead you to properly label "COMMUNITY:  good first issue" by [@&#8203;aendel](https://github.com/aendel) in [QwikDev/qwik#5726
-   docs: fixed CodeSandbox/CodeFile src paths to match github files by [@&#8203;aendel](https://github.com/aendel) in [QwikDev/qwik#5725
-   fix: Uppercase handling for SameSite cookie values by [@&#8203;ksjogo](https://github.com/ksjogo) in [QwikDev/qwik#5603
-   feat(link): prefetch symbols by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5480
-   docs: Fixed various typos (or misspelled words) in documentation files by [@&#8203;aendel](https://github.com/aendel) in [QwikDev/qwik#5728
-   chore: extra type tests by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5580
-   fix(build): qwik binary path in package.json by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5729
-   fix(routing): fallback to hard navigation when soft navigation fails. by [@&#8203;iamriajul](https://github.com/iamriajul) in [QwikDev/qwik#5521
-   fix(JSX): remove Promise from FC by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5730
-   fix(core): serialize the 'key' attribute of JSX nodes by [@&#8203;yanivhamo](https://github.com/yanivhamo) in [QwikDev/qwik#5501
-   fix(repl): give monaco the names of the imports by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5734
-   docs(cookbook): add Combine Request Handlers example by [@&#8203;gioboa](https://github.com/gioboa) and [@&#8203;erikras](https://github.com/erikras) in [QwikDev/qwik#5733
-   fix(docs): grammar in "Project Structure" page by [@&#8203;ChallengeHandler](https://github.com/ChallengeHandler) in [QwikDev/qwik#5735
-   chore: 1.4.0 by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5736

##### New Contributors

-   [@&#8203;blueagler](https://github.com/blueagler) made their first contribution in [QwikDev/qwik#5695
-   [@&#8203;linkfang](https://github.com/linkfang) made their first contribution in [QwikDev/qwik#5710
-   [@&#8203;Balastrong](https://github.com/Balastrong) made their first contribution in [QwikDev/qwik#5718
-   [@&#8203;thenhawke](https://github.com/thenhawke) made their first contribution in [QwikDev/qwik#5720
-   [@&#8203;aendel](https://github.com/aendel) made their first contribution in [QwikDev/qwik#5726
-   [@&#8203;ksjogo](https://github.com/ksjogo) made their first contribution in [QwikDev/qwik#5603
-   [@&#8203;yanivhamo](https://github.com/yanivhamo) made their first contribution in [QwikDev/qwik#5501
-   [@&#8203;ChallengeHandler](https://github.com/ChallengeHandler) made their first contribution in [QwikDev/qwik#5735

**Full Changelog**: QwikDev/qwik@v1.3.5...v1.4.0

### [`v1.3.5`](https://github.com/BuilderIO/qwik/releases/tag/v1.3.5)

[Compare Source](https://github.com/BuilderIO/qwik/compare/v1.3.4...v1.3.5)

#### What's Changed

-   docs: fix typos for theme management cookbook by [@&#8203;harshmangalam](https://github.com/harshmangalam) in [QwikDev/qwik#5698
-   fix(labs): double slash when used with BASE_URL by [@&#8203;mhevery](https://github.com/mhevery) in [QwikDev/qwik#5700
-   fix: improve escapeText and unescapeText replace to prevent XSS by [@&#8203;ignatvilesov](https://github.com/ignatvilesov) in [QwikDev/qwik#5701
-   chore: allow any undici version by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5703
-   docs(propfunctionprops): mark propfunctionprops as deprecated by [@&#8203;maiieul](https://github.com/maiieul) in [QwikDev/qwik#5680
-   chore: 1.3.5 by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5704

**Full Changelog**: QwikDev/qwik@v1.3.4...v1.3.5

### [`v1.3.4`](https://github.com/BuilderIO/qwik/releases/tag/v1.3.4)

[Compare Source](https://github.com/BuilderIO/qwik/compare/v1.3.3...v1.3.4)

##### What's Changed

-   chore: update deps + monaco by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5685
-   chore: Remove duplicated dist directory from .prettierignore by [@&#8203;nelsonprsousa](https://github.com/nelsonprsousa) in [QwikDev/qwik#5687
-   docs: add og-img integration guide by [@&#8203;fabian-hiller](https://github.com/fabian-hiller) in [QwikDev/qwik#5686
-   chore: improve FunctionComponent by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5688
-   fix: improve escapeText replace by [@&#8203;ignatvilesov](https://github.com/ignatvilesov) in [QwikDev/qwik#5689
-   fix(optimizer): use correct prop in omit by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5690
-   chore: 1.3.4 by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5691
-   docs: fix typos for nav link cookbook  by [@&#8203;harshmangalam](https://github.com/harshmangalam) in [QwikDev/qwik#5694

##### New Contributors

-   [@&#8203;ignatvilesov](https://github.com/ignatvilesov) made their first contribution in [QwikDev/qwik#5689

**Full Changelog**: QwikDev/qwik@v1.3.3...v1.3.4

### [`v1.3.3`](https://github.com/BuilderIO/qwik/releases/tag/v1.3.3)

[Compare Source](https://github.com/BuilderIO/qwik/compare/v1.3.2...v1.3.3)

##### What's Changed

-   fix(cli): Update jokes.json by [@&#8203;mayank99](https://github.com/mayank99) in [QwikDev/qwik#5657
-   docs: for accessing the .env variables in serverfull architechture example in express by [@&#8203;sreeisalso](https://github.com/sreeisalso) in [QwikDev/qwik#5619
-   docs: change placement of {...props}  and add section by [@&#8203;Adbib](https://github.com/Adbib) in [QwikDev/qwik#5664
-   docs: Update build command in Static Site Generation (SSG) Overview docs by [@&#8203;lelouchB](https://github.com/lelouchB) in [QwikDev/qwik#5668
-   fix(starter): rename tailwind postcss.config file by [@&#8203;iamriajul](https://github.com/iamriajul) in [QwikDev/qwik#5669
-   fix: fixing running qwik-development-server on windows machine by [@&#8203;hassanzohdy](https://github.com/hassanzohdy) in [QwikDev/qwik#5593
-   fix(starter): add vite plugin type by [@&#8203;iamriajul](https://github.com/iamriajul) in [QwikDev/qwik#5670
-   feat(qwik-react): directive aliases for Astro and other package conflicts by [@&#8203;thejackshelton](https://github.com/thejackshelton) in [QwikDev/qwik#5651
-   feat: qwik-prefetch-worker by [@&#8203;mhevery](https://github.com/mhevery) in [QwikDev/qwik#5618
-   refactor: Clarify var naming qwikloader.ts by [@&#8203;gabrielgrant](https://github.com/gabrielgrant) in [QwikDev/qwik#5546
-   docs: fix entry file name by [@&#8203;AustinGil](https://github.com/AustinGil) in [QwikDev/qwik#5646
-   feat(labs): Support base prefix in untypedAppUrl by [@&#8203;tera-ny](https://github.com/tera-ny) in [QwikDev/qwik#5615
-   style(starter templates): updates to starter templates names by [@&#8203;abstractalgo](https://github.com/abstractalgo) in [QwikDev/qwik#5479
-   fix: Clearer error message for `resolveValue` for `head` function by [@&#8203;colelawrence](https://github.com/colelawrence) in [QwikDev/qwik#5624
-   refactor(starter): add alt attribute in order to improve accessibility by [@&#8203;tidiview](https://github.com/tidiview) in [QwikDev/qwik#5674
-   refactor(insights): remove netlify.toml causing confusion by [@&#8203;mhevery](https://github.com/mhevery) in [QwikDev/qwik#5676
-   feat(cookbook): add Algolia search by [@&#8203;gioboa](https://github.com/gioboa) in [QwikDev/qwik#5675
-   fix(cookbook): change Algolia example by [@&#8203;gioboa](https://github.com/gioboa) in [QwikDev/qwik#5677
-   fix: polymorphic component types by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5672
-   chore: add Nix build flake environment by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5594
-   fix(nix): missing .envrc by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5678
-   fix(nix): make rust and wasm builds work by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5679
-   fix: dynamic refs by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5681
-   fix(core): Make polymorphic components easy by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5682
-   chore: 1.3.3 by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5683

##### New Contributors

-   [@&#8203;mayank99](https://github.com/mayank99) made their first contribution in [QwikDev/qwik#5657
-   [@&#8203;lelouchB](https://github.com/lelouchB) made their first contribution in [QwikDev/qwik#5668
-   [@&#8203;hassanzohdy](https://github.com/hassanzohdy) made their first contribution in [QwikDev/qwik#5593
-   [@&#8203;AustinGil](https://github.com/AustinGil) made their first contribution in [QwikDev/qwik#5646
-   [@&#8203;tera-ny](https://github.com/tera-ny) made their first contribution in [QwikDev/qwik#5615

**Full Changelog**: QwikDev/qwik@v1.3.2...v1.3.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 9pm on sunday" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ascorbic/unpic-img).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
@intellix
Copy link
Contributor

intellix commented Jul 26, 2024

as opposed to the simple application example, do you have an example of how to integrate this when you have MFEs and different languages? For example we currently have an Angular app hosting our Qwik MFE and we plan to introduce additional Qwik MFEs before we change the host later:

<head>
  <title>Angular app</title>
</head>
<body>
  <my-angular-app />
  
  <!-- MFE 1 -->
  <iframe src="qwik-app1.com">
    <head>
      <title>Qwik App 1</title>
      <PrefetchServiceWorker />
      <PrefetchGraph />
    </head>
    ...
  </iframe>

  <!-- MFE 2 -->
  <iframe src="qwik-app2.com">
    <head>
      <title>Qwik App 2</title>
      <PrefetchServiceWorker />
      <PrefetchGraph />
    </head>
    ...
  </iframe>
</body>

Or should the PrefetchServiceWorker exist in the host only, and the iframes only have the PrefetchGraph? What about host apps that aren't JSX like Angular

@thejackshelton
Copy link
Member

as opposed to the simple application example, do you have an example of how to integrate this when you have MFEs and different languages? For example we currently have an Angular app hosting our Qwik MFE and we plan to introduce additional Qwik MFEs before we change the host later:

<head>
  <title>Angular app</title>
</head>
<body>
  <my-angular-app />
  
  <!-- MFE 1 -->
  <iframe src="qwik-app1.com">
    <head>
      <title>Qwik App 1</title>
      <PrefetchServiceWorker />
      <PrefetchGraph />
    </head>
    ...
  </iframe>

  <!-- MFE 2 -->
  <iframe src="qwik-app2.com">
    <head>
      <title>Qwik App 2</title>
      <PrefetchServiceWorker />
      <PrefetchGraph />
    </head>
    ...
  </iframe>
</body>

Or should the PrefetchServiceWorker exist in the host only, and the iframes only have the PrefetchGraph? What about host apps that aren't JSX like Angular

There should only be one prefetch service worker on the page, and then the prefetch graphs in each MFE. As for apps that aren't JSX I'm not sure 🤔 , maybe taking the js of the prefetch graph and adding that to the angular parts? 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants