Skip to content

Commit

Permalink
WIP: fix broken e2e tests
Browse files Browse the repository at this point in the history
  • Loading branch information
mhevery committed Jan 3, 2024
1 parent f3d4fa3 commit f1127a9
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 7 deletions.
6 changes: 6 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,13 @@
"dependencies": {
"esbuild-plugin-raw": "^0.1.7"
},
"comments": {
"01": "devDependencies includes reference to @builder.io/qwik: workspace: *. This is needed or e2e tests will fail",
"02": " It would be nice to be able to remove this dependency and fix the test.",
"03": "devDependencies can't include reference to @builder.io/qwik-city or e2e test will fail."
},
"devDependencies": {
"@builder.io/qwik": "workspace:*",
"@builder.io/partytown": "^0.8.1",
"@clack/prompts": "^0.7.0",
"@mdx-js/mdx": "2.3.0",
Expand Down
8 changes: 1 addition & 7 deletions packages/qwik/src/optimizer/src/plugins/vite.unit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,7 @@ function mockOptimizerOptions(): OptimizerOptions {
}

const includeDeps = undefined;
const noExternal = [
'@builder.io/qwik',
'@builder.io/qwik/server',
'@builder.io/qwik/build',
'@builder.io/qwik-city',
];
const noExternal = ['@builder.io/qwik', '@builder.io/qwik/server', '@builder.io/qwik/build'];

const excludeDeps = [
'@vite/client',
Expand All @@ -40,7 +35,6 @@ const excludeDeps = [
'@builder.io/qwik/jsx-dev-runtime',
'@builder.io/qwik/build',
'@qwik-client-manifest',
'@builder.io/qwik-city',
];

test('command: serve, mode: development', async () => {
Expand Down
3 changes: 3 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit f1127a9

Please sign in to comment.