fix: use existing local .eslintrc configuration #5563

gioboa · 2023-12-11T22:24:28Z

With this PR, priority is given to the configuration that eslint can load from the project.
if it is invalid or does not exist eslintConfig.parser === null then we fallback to the one we have always used.

Closed QwikDev#5555 QwikDev#5460

netlify · 2023-12-11T22:24:31Z

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	`925188c`

PatrickJS · 2023-12-12T07:26:48Z

can we tell the dev if their config is invalid (but only if its invalid and exists)

maiieul

Tested on the 𝕏 stack. Looks like it's working 👍

gioboa · 2023-12-12T10:23:40Z

can we tell the dev if their config is invalid (but only if its invalid and exists)

eslint config is invalid

if there is no parser object in the config
if there is no eslint config file
other cases that I didn't explore

so we need to test all the cases to print a good message in the terminal.

This is an internal linter, I don't think we need to bug the developer for that.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@builder.io/qwik](https://qwik.builder.io/) ([source](https://github.com/BuilderIO/qwik/tree/HEAD/packages/qwik)) | [`1.3.0` -> `1.3.1`](https://renovatebot.com/diffs/npm/@builder.io%2fqwik/1.3.0/1.3.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@builder.io%2fqwik/1.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@builder.io%2fqwik/1.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@builder.io%2fqwik/1.3.0/1.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@builder.io%2fqwik/1.3.0/1.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>BuilderIO/qwik (@builder.io/qwik)</summary> ### [`v1.3.1`](https://github.com/BuilderIO/qwik/releases/tag/v1.3.1) [Compare Source](https://github.com/BuilderIO/qwik/compare/v1.3.0...v1.3.1) ##### What's Changed - fix(playground): block 1.3.0 by [@wmertens](https://github.com/wmertens) in [QwikDev/qwik#5538 - docs: show-updated-docs by [@AmirSa12](https://github.com/AmirSa12) in [QwikDev/qwik#5516 - docs: (add list item) Add qwik-d3 to the library list by [@gilf](https://github.com/gilf) in [QwikDev/qwik#5544 - docs: add qwik-storefront-ui library by [@gioboa](https://github.com/gioboa) in [QwikDev/qwik#5548 - docs: change image url by [@gioboa](https://github.com/gioboa) in [QwikDev/qwik#5549 - chore(starters): add type module to package.json by [@nelsonprsousa](https://github.com/nelsonprsousa) in [QwikDev/qwik#5553 - refactor(types): optimize, QRL props, PropsOf, track(Signal) type, ... by [@wmertens](https://github.com/wmertens) in [QwikDev/qwik#5550 - fix(repl): don't propose broken versions by [@wmertens](https://github.com/wmertens) in [QwikDev/qwik#5560 - fix: remove dependency on vitefu causing playground failures by [@mhevery](https://github.com/mhevery) in [QwikDev/qwik#5562 - fix: better deprecation notice on qwikevents by [@wmertens](https://github.com/wmertens) in [QwikDev/qwik#5568 - fix: use existing local .eslintrc configuration by [@gioboa](https://github.com/gioboa) in [QwikDev/qwik#5563 - test(lint): break up lint tests into separate files by [@mhevery](https://github.com/mhevery) in [QwikDev/qwik#5572 - refactor(qwik): add `__qwik_serializable__` brand to types by [@mhevery](https://github.com/mhevery) in [QwikDev/qwik#5576 - fix(lint): allow event methods to capture `PropFunction` by [@mhevery](https://github.com/mhevery) in [QwikDev/qwik#5578 - chore(eslint-plugin-qwik): add 'qwik/no-use-visible-task': 'warn' to strict by [@maiieul](https://github.com/maiieul) in [QwikDev/qwik#5575 - fix: `server$` and AbortSignal types by [@mhevery](https://github.com/mhevery) in [QwikDev/qwik#5581 - fix(qwik): restore bivarience hack by [@mhevery](https://github.com/mhevery) in [QwikDev/qwik#5587 - chore(insights): correct failing build by [@mhevery](https://github.com/mhevery) in [QwikDev/qwik#5586 - docs(usevisibletask$): reduce eslint noUseVisibleTask message + transfer to docs by [@maiieul](https://github.com/maiieul) in [QwikDev/qwik#5583 - docs: remove console warning by [@gioboa](https://github.com/gioboa) in [QwikDev/qwik#5590 - fix(qwik-city): Scroll Position doesn't reset to 0 when it was triggered by an Action. by [@iamriajul](https://github.com/iamriajul) in [QwikDev/qwik#5588 - feat(qwik): Experimental support for synchronous QRL `sync$()`. by [@mhevery](https://github.com/mhevery) in [QwikDev/qwik#5545 - chore: 1.3.1 by [@mhevery](https://github.com/mhevery) in [QwikDev/qwik#5595 ##### New Contributors - [@AmirSa12](https://github.com/AmirSa12) made their first contribution in [QwikDev/qwik#5516 - [@iamriajul](https://github.com/iamriajul) made their first contribution in [QwikDev/qwik#5588 **Full Changelog**: QwikDev/qwik@v1.3.0...v1.3.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9pm on sunday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ascorbic/unpic-img).

fix: use existing local .eslintrc configuration

925188c

Closed QwikDev#5555 QwikDev#5460

gioboa added the COMP: eslint label Dec 11, 2023

PatrickJS approved these changes Dec 12, 2023

View reviewed changes

maiieul approved these changes Dec 12, 2023

View reviewed changes

wmertens merged commit a499803 into QwikDev:main Dec 12, 2023
22 checks passed

gioboa deleted the fix/eslint branch December 12, 2023 16:59

gioboa linked an issue Dec 12, 2023 that may be closed by this pull request

[✨] Remove this warning: routeLoader$() can only be declared in layout.tsx, index.tsx and plugin.tsx inside the src/routes directory #5460

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: use existing local .eslintrc configuration #5563

fix: use existing local .eslintrc configuration #5563

gioboa commented Dec 11, 2023

netlify bot commented Dec 11, 2023

PatrickJS commented Dec 12, 2023 •

edited

Loading

maiieul left a comment

gioboa commented Dec 12, 2023

fix: use existing local .eslintrc configuration #5563

fix: use existing local .eslintrc configuration #5563

Conversation

gioboa commented Dec 11, 2023

netlify bot commented Dec 11, 2023

👷 Deploy request for qwik-insights pending review.

PatrickJS commented Dec 12, 2023 • edited Loading

maiieul left a comment

Choose a reason for hiding this comment

gioboa commented Dec 12, 2023

PatrickJS commented Dec 12, 2023 •

edited

Loading