Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starters): add type module to package.json #5553

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

nelsonprsousa
Copy link
Contributor

Overview

Fix the following warning after vite was upgraded to v5.x in qwik v.1.3.0:
image

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Adding type: module to the package.json of the base app starter.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link

netlify bot commented Dec 10, 2023

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit e2c7548

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gioboa gioboa changed the title chore: Add type: module to package.json base app starters after vite upgrade to v5 chore(starters): add type module to package.json Dec 10, 2023
@gioboa gioboa merged commit 609d070 into QwikDev:main Dec 10, 2023
23 checks passed
kodiakhq bot pushed a commit to ascorbic/unpic-img that referenced this pull request Dec 17, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@builder.io/qwik](https://qwik.builder.io/) ([source](https://github.com/BuilderIO/qwik/tree/HEAD/packages/qwik)) | [`1.3.0` -> `1.3.1`](https://renovatebot.com/diffs/npm/@builder.io%2fqwik/1.3.0/1.3.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@builder.io%2fqwik/1.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@builder.io%2fqwik/1.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@builder.io%2fqwik/1.3.0/1.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@builder.io%2fqwik/1.3.0/1.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>BuilderIO/qwik (@&#8203;builder.io/qwik)</summary>

### [`v1.3.1`](https://github.com/BuilderIO/qwik/releases/tag/v1.3.1)

[Compare Source](https://github.com/BuilderIO/qwik/compare/v1.3.0...v1.3.1)

##### What's Changed

-   fix(playground): block 1.3.0 by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5538
-   docs: show-updated-docs by [@&#8203;AmirSa12](https://github.com/AmirSa12) in [QwikDev/qwik#5516
-   docs: (add list item) Add qwik-d3 to the library list by [@&#8203;gilf](https://github.com/gilf) in [QwikDev/qwik#5544
-   docs: add qwik-storefront-ui library by [@&#8203;gioboa](https://github.com/gioboa) in [QwikDev/qwik#5548
-   docs: change image url by [@&#8203;gioboa](https://github.com/gioboa) in [QwikDev/qwik#5549
-   chore(starters): add type module to package.json  by [@&#8203;nelsonprsousa](https://github.com/nelsonprsousa) in [QwikDev/qwik#5553
-   refactor(types): optimize, QRL props, PropsOf, track(Signal) type, ... by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5550
-   fix(repl): don't propose broken versions by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5560
-   fix: remove dependency on vitefu causing playground failures by [@&#8203;mhevery](https://github.com/mhevery) in [QwikDev/qwik#5562
-   fix: better deprecation notice on qwikevents by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5568
-   fix: use existing local .eslintrc configuration by [@&#8203;gioboa](https://github.com/gioboa) in [QwikDev/qwik#5563
-   test(lint): break up lint tests into separate files by [@&#8203;mhevery](https://github.com/mhevery) in [QwikDev/qwik#5572
-   refactor(qwik): add `__qwik_serializable__` brand to types by [@&#8203;mhevery](https://github.com/mhevery) in [QwikDev/qwik#5576
-   fix(lint): allow event methods to capture `PropFunction` by [@&#8203;mhevery](https://github.com/mhevery) in [QwikDev/qwik#5578
-   chore(eslint-plugin-qwik): add 'qwik/no-use-visible-task': 'warn' to strict by [@&#8203;maiieul](https://github.com/maiieul) in [QwikDev/qwik#5575
-   fix: `server$` and AbortSignal types by [@&#8203;mhevery](https://github.com/mhevery) in [QwikDev/qwik#5581
-   fix(qwik): restore bivarience hack by [@&#8203;mhevery](https://github.com/mhevery) in [QwikDev/qwik#5587
-   chore(insights): correct failing build by [@&#8203;mhevery](https://github.com/mhevery) in [QwikDev/qwik#5586
-   docs(usevisibletask$): reduce eslint noUseVisibleTask message + transfer to docs by [@&#8203;maiieul](https://github.com/maiieul) in [QwikDev/qwik#5583
-   docs: remove console warning by [@&#8203;gioboa](https://github.com/gioboa) in [QwikDev/qwik#5590
-   fix(qwik-city): Scroll Position doesn't reset to 0 when it was triggered by an Action. by [@&#8203;iamriajul](https://github.com/iamriajul) in [QwikDev/qwik#5588
-   feat(qwik): Experimental support for synchronous QRL `sync$()`. by [@&#8203;mhevery](https://github.com/mhevery) in [QwikDev/qwik#5545
-   chore: 1.3.1 by [@&#8203;mhevery](https://github.com/mhevery) in [QwikDev/qwik#5595

##### New Contributors

-   [@&#8203;AmirSa12](https://github.com/AmirSa12) made their first contribution in [QwikDev/qwik#5516
-   [@&#8203;iamriajul](https://github.com/iamriajul) made their first contribution in [QwikDev/qwik#5588

**Full Changelog**: QwikDev/qwik@v1.3.0...v1.3.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 9pm on sunday" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ascorbic/unpic-img).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy45My4xIiwidXBkYXRlZEluVmVyIjoiMzcuOTMuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants