Coverage test: coins tests #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieuvubk
requested review from
faddat,
mustafapylons,
MikeSofaer and
faisalnaveedRNS
as code owners
faddat
approved these changes
Jun 29, 2022
x/pylons/keeper/coins_test.go
Outdated
| @@ -47,3 +47,126 @@ func (suite *IntegrationTestSuite) TestMintCoinsToAddr() { | |||
| balance := bk.SpendableCoins(ctx, addr) | |||
| require.True(balance.IsEqual(mintAmt)) | |||
| } | |||
|
|
|||
| func (suite *IntegrationTestSuite) TestBurnCoins() { | |||
| // k, ctx := setupKeeper(t) | |||
x/pylons/keeper/coins_test.go
Outdated
| } | ||
|
|
||
| func (suite *IntegrationTestSuite) TestBurnCoinsFromAddress() { | ||
| // k, ctx := setupKeeper(t) |
x/pylons/keeper/coins_test.go
Outdated
| } | ||
|
|
||
| func (suite *IntegrationTestSuite) TestMintCreditToAddr() { | ||
| // k, ctx := setupKeeper(t) |
There was a problem hiding this comment.
This dead code can be removed as well
x/pylons/keeper/coins_test.go
Outdated
| } | ||
|
|
||
| func (suite *IntegrationTestSuite) TestSendRewardsFromFeeCollector() { | ||
| // k, ctx := setupKeeper(t) |
There was a problem hiding this comment.
This dead code can be removed as well.
faisalnaveedRNS
approved these changes
Jun 29, 2022
x/pylons/keeper/coins_test.go
Outdated
| err := k.MintCoins(ctx, types.PaymentsProcessorName, mintAmt) | ||
| require.NoError(err) | ||
|
|
||
| // PaymentsProcessor account has buner permissions |
There was a problem hiding this comment.
"PaymentsProcessor account has burner permissions" would be the right comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr is to add the test case in issue #497.
Now coins tests available, I'll write more test for another tasks