Testing Coverage

[aljo242]

coverage.txt

Summary

Some features have been added without being adequately tested. This issue covers a backlog of unfinished tests.

Problem Definition

Here is the latest coverage.txt.

Key files with incomplete or no testing are:

• app/ante.go custom ante handler testing
• x/pylons/client/cli/tx_burn_debt_token.go no tests
• x/pylons/keeper/complete_pending_execution.go unfinished
• x/pylons/keeper/coins.go unfinished
• x/pylons/keeper/env_collection.go unfinished
• x/pylons/keeper/grpc_query_list_trades_by_creator.go no tests
• x/pylons/keeper/msg_server_burn_debt_token.go no tests
• x/pylons/keeper/msg_server_execute_recipe.go unfinished
• x/pylons/keeper/msg_server_fulfill_trade.go unfinished
• x/pylons/keeper/msg_server_process_payment_info.go no tests
• x/pylons/types/cel_decls.go unfinished or perhaps dead code
• x/pylons/types/program.go unfinished or perhaps dead code
• x/pylons/types/recipe_item_params.go unfinished
• x/pylons/types/recipe_weight_table unfinished
• x/pylons/types/item.go unfinished
• x/pylons/types/recipe.go tests for RecipeModified(), ItemInputsEqual(), EntriesListEqual() and OutputsEqual() functions
• x/pylons/types/validate_common_fields test for ValidateItemField()

Proposal

Most tests can be based off of the existing testing runner setups we have. We just need specific plans and to ensure coverage.

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[BlackPanthar]

Lets do an assignment sheet like we did last time and use that as the basis to gradually improve our coverage

[aljo242]

Sure, but I think we should try to keep it all on Github, so things can be more easily tracked. Add a comment with the tests you'd like to tackle!

[BlackPanthar]

x/pylons/keeper/msg_server_execute_recipe.go unfinished
x/pylons/types/cel_decls.go unfinished or perhaps dead code
x/pylons/types/program.go unfinished or perhaps dead code
x/pylons/types/recipe_item_params.go unfinished
x/pylons/types/recipe_weight_table unfinished
x/pylons/types/item.go unfinished
x/pylons/types/recipe.go tests for RecipeModified(), ItemInputsEqual(), EntriesListEqual() and OutputsEqual() functions
x/pylons/types/validate_common_fields test for ValidateItemField()