Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making CrashesToMarkUnhealthy optional #300

Merged
merged 3 commits into from
Jul 11, 2022
Merged

making CrashesToMarkUnhealthy optional #300

merged 3 commits into from
Jul 11, 2022

Conversation

dgkanatsios
Copy link
Collaborator

@dgkanatsios dgkanatsios commented Jul 11, 2022

Fixes #215

This PR makes the CrashesToMarkUnhealthy field optional, so that a GameServerBuild will continue scaling operations even if the GameServers keep crashing.

We need to update documentation to clarify that there is no default anymore.

@dgkanatsios dgkanatsios marked this pull request as ready for review July 11, 2022 04:29
@@ -81,7 +81,6 @@ spec:
type: object
type: array
crashesToMarkUnhealthy:
default: 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By removing this, the default value is nil now right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crashesToMarkUnhealthy should have an option to keep scaling even if GameServerBuild is Unhealthy
2 participants