Fix singular translation issues & accessibility improvements #2119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acicovic
approved these changes
Jan 16, 2024
… into fix/translation-and-a11y-issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces some improvements to the Parse.ly plugin. It adds aria labels to previous and next navigations on the Dashboard Widget, enhancing user accessibility and experience. Additionally, it removes an unnecessary translatable string and fixes a translation issue in the
getPeriodDescription()function. The latter change ensures accurate display of time-related strings in various languages, addressing issues with singular and plural forms.These issues have been reported in #2033 and closes it.
Motivation and context
The update is addresses a specific bug in the
getPeriodDescription()function, as discussed in the original issue. This bug affected the handling of singular and plural forms in languages like Russian. Improving accessibility in the Dashboard Widget and refining the overall user experience are also motivations for these changes.How has this been tested?
Tested on my local environment and validated if the strings are still correctly displayed, and using Voice Over, if the newly added aria labels are used instead of the button text.
Screenshots (if appropriate)
N/A