Fix singular translation issues & accessibility improvements (#2119)

* Fix PHPStan issue * Add area labels to previous and next navigations on the Dashboard Widget * Remove unnecessary translatable string * Change singular translations on getPeriodDescription() function * Add build files * Used, Yoda conditions must be. --------- Co-authored-by: Alex Cicovic <23142906+acicovic@users.noreply.github.com>
Parsely · Jan 16, 2024 · 3f08cf1 · 3f08cf1
1 parent d33d431
commit 3f08cf1
Show file tree

Hide file tree

Showing 7 changed files with 23 additions and 9 deletions.
diff --git a/build/content-helper/dashboard-widget.asset.php b/build/content-helper/dashboard-widget.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-api-fetch', 'wp-components', 'wp-element', 'wp-i18n', 'wp-url'), 'version' => 'eb2c678672339effd351');
+<?php return array('dependencies' => array('react', 'wp-api-fetch', 'wp-components', 'wp-element', 'wp-i18n', 'wp-url'), 'version' => 'bc8a9708da1acc75b14d');
diff --git a/build/content-helper/dashboard-widget.js b/build/content-helper/dashboard-widget.js
diff --git a/build/content-helper/editor-sidebar.asset.php b/build/content-helper/editor-sidebar.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-api-fetch', 'wp-components', 'wp-core-data', 'wp-data', 'wp-edit-post', 'wp-editor', 'wp-element', 'wp-i18n', 'wp-plugins', 'wp-primitives', 'wp-url'), 'version' => '87b2ffe95f05776cd359');
+<?php return array('dependencies' => array('react', 'wp-api-fetch', 'wp-components', 'wp-core-data', 'wp-data', 'wp-edit-post', 'wp-editor', 'wp-element', 'wp-i18n', 'wp-plugins', 'wp-primitives', 'wp-url'), 'version' => 'b23d9ca630bca23c9955');
diff --git a/build/content-helper/editor-sidebar.js b/build/content-helper/editor-sidebar.js
diff --git a/src/content-helper/common/utils/constants.ts b/src/content-helper/common/utils/constants.ts
@@ -90,20 +90,32 @@ export function getPeriodDescription(
 	/* eslint-disable @wordpress/valid-sprintf */
 	switch ( timeUnit ) {
 		case 'm':
+			if ( 1 === timeValue ) {
+				description = __( 'Last Minute', 'wp-parsely' );
+				break;
+			}
 			description = sprintf( /* translators: 1: Number of minutes */
-				_n( 'Last Minute', 'Last %1$d Minutes', timeValue, 'wp-parsely' ),
+				_n( 'Last %1$d Minute', 'Last %1$d Minutes', timeValue, 'wp-parsely' ),
 				timeValue
 			);
 			break;
 		case 'h':
+			if ( 1 === timeValue ) {
+				description = __( 'Last Hour', 'wp-parsely' );
+				break;
+			}
 			description = sprintf( /* translators: 1: Number of hours */
-				_n( 'Last Hour', 'Last %1$d Hours', timeValue, 'wp-parsely' ),
+				_n( 'Last %1$d Hour', 'Last %1$d Hours', timeValue, 'wp-parsely' ),
 				timeValue
 			);
 			break;
 		case 'd':
+			if ( 1 === timeValue ) {
+				description = __( 'Last Day', 'wp-parsely' );
+				break;
+			}
 			description = sprintf( /* translators: 1: Number of days */
-				_n( 'Last Day', 'Last %1$d Days', timeValue, 'wp-parsely' ),
+				_n( 'Last %1$d Day', 'Last %1$d Days', timeValue, 'wp-parsely' ),
 				timeValue
 			);
 			break;

diff --git a/src/content-helper/common/utils/post.tsx b/src/content-helper/common/utils/post.tsx
@@ -87,7 +87,7 @@ export function PostListItemMetric(
 
 	return (
 		<span className="parsely-top-post-metric-data">
-			{ __( '-', 'wp-parsely' ) }
+			-
 		</span>
 	);
 }

diff --git a/src/content-helper/dashboard-widget/components/top-posts.tsx b/src/content-helper/dashboard-widget/components/top-posts.tsx
@@ -186,6 +186,7 @@ export function TopPosts(): JSX.Element {
 			<button
 				className="parsely-top-posts-navigation-prev"
 				disabled={ page <= 1 }
+				aria-label={ __( 'Previous page', 'wp-parsely' ) }
 				onClick={ () => {
 					setPage( page - 1 );
 					Telemetry.trackEvent( 'dash_widget_navigation', {
@@ -205,6 +206,7 @@ export function TopPosts(): JSX.Element {
 			<button
 				className="parsely-top-posts-navigation-next"
 				disabled={ ! loading && posts.length < TOP_POSTS_DEFAULT_LIMIT }
+				aria-label={ __( 'Next page', 'wp-parsely' ) }
 				onClick={ () => {
 					setPage( page + 1 );
 					Telemetry.trackEvent( 'dash_widget_navigation', {