Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework releases #43

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Rework releases #43

merged 2 commits into from
Sep 19, 2024

Commits on Sep 17, 2024

  1. Rework releasing 

    This commit changes how releases are made. Previously a release based on
a tag was done as the first step and `actions/upload-release-asset` was
then used to submit build artifacts to it. That action, however, is
obsoleted and will stop working in the future.

The new approach first builds everything, then uses
`softprops/action-gh-release` to create the release once all the build
artifacts are collected. This allows for some handy improvements like
providing sha1sum of each build artifact.

I tried automating generating the summary of installed packages and
their versions, but all my attempts at that failed, probably due to
running vcpkg outside of `lukka/run-vcpkg` action, which maybe creates
some special environment? Setting `VCPKG_ROOT`, `VCPKG_INSTALLED_DIR`
for relevant jobs yielded no improvements.
    @janisozaur
    janisozaur committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    5fda960 View commit details
    Browse the repository at this point in the history

  2. Rework how version is obtained 

    In previous approach version would be set in each job individually,
potentially leading to divergence. The new approach sets the version in
first step as job output, which is then consumed by all the other jobs
in the workflow.
    @janisozaur
    janisozaur committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    7f1b994 View commit details
    Browse the repository at this point in the history