Rework releases #43
Merged
Rework releases #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes how releases are made. Previously a release based on a tag was done as the first step and `actions/upload-release-asset` was then used to submit build artifacts to it. That action, however, is obsoleted and will stop working in the future. The new approach first builds everything, then uses `softprops/action-gh-release` to create the release once all the build artifacts are collected. This allows for some handy improvements like providing sha1sum of each build artifact. I tried automating generating the summary of installed packages and their versions, but all my attempts at that failed, probably due to running vcpkg outside of `lukka/run-vcpkg` action, which maybe creates some special environment? Setting `VCPKG_ROOT`, `VCPKG_INSTALLED_DIR` for relevant jobs yielded no improvements.
In previous approach version would be set in each job individually, potentially leading to divergence. The new approach sets the version in first step as job output, which is then consumed by all the other jobs in the workflow.
tupaschoal
reviewed
Sep 17, 2024
tupaschoal
approved these changes
Sep 18, 2024
Gymnasiast
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework releases:
This commit changes how releases are made. Previously a release based on
a tag was done as the first step and
actions/upload-release-assetwasthen used to submit build artifacts to it. That action, however, is
obsoleted and will stop working in the future.
The new approach first builds everything, then uses
softprops/action-gh-releaseto create the release once all the buildartifacts are collected. This allows for some handy improvements like
providing sha1sum of each build artifact.
I tried automating generating the summary of installed packages and
their versions, but all my attempts at that failed, probably due to
running vcpkg outside of
lukka/run-vcpkgaction, which maybe createssome special environment? Setting
VCPKG_ROOT,VCPKG_INSTALLED_DIRfor relevant jobs yielded no improvements.
Rework how version is obtained:
In previous approach version would be set in each job individually,
potentially leading to divergence. The new approach sets the version in
first step as job output, which is then consumed by all the other jobs
in the workflow.
I intend to implement similar flow for main OpenRCT2 repository, to address OpenRCT2/OpenRCT2#22737