8.2.3 #19
Merged
8.2.3 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Real-Time Clock isn't set, and if we're not setting via the wifi module then the YEAR_MIN should now be a bit more recent to save button pushes. Perhaps YEAR_MAX for the pushbutton menu interface should be more than 10 years later? What's the expected lifespan of this system before we'd expect firmware updates to be applied?
RTC setting improvement via push button menu
|
@KipK can you also remove the 3ph env from the GitHub workflow? |
|
efb16c4 does this ain't it? |
|
Hum... The check is still failing.... https://github.com/OpenEVSE/open_evse/actions/runs/4672244148/jobs/8348851478#step:7:1 |
|
Seems it still use the old one as it's not merged yet |
|
Yeah I guess it is... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
has to redo PR #18 to solve conflicts. Looks all good here
for the release, a Warning should display that wifi fw > 4.1.7 is mandatory, it won't unlock evse module if not.
This should then be released only when the next wifi fw release is published.