Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge latest changes from Lincomatic V8.2.1 > V8.2.3 #18

Closed
wants to merge 11 commits into from

Conversation

glynhudson
Copy link
Collaborator

@glynhudson glynhudson commented Apr 5, 2023

20230206 SCL

20220408 V8.2.1 SCL

  • fix bug: SaveSettings() should save GetMaxCurrentCapacity() instead of GetCurrentCapacity(), in case called during throttling

lincomatic and others added 11 commits April 8, 2022 18:08
If Real-Time Clock isn't set, and if we're not setting via the wifi module then the YEAR_MIN should now be a bit more recent to save button pushes.
Perhaps YEAR_MAX for the pushbutton menu interface should be more than 10 years later? What's the expected lifespan of this system before we'd expect firmware updates to be applied?
RTC setting improvement via push button menu
@glynhudson glynhudson changed the title V8.2.1 > V8.2.3 Merge latest changes from Lincomatic V8.2.1 > V8.2.3 Apr 5, 2023
@glynhudson
Copy link
Collaborator Author

@jeremypoulter please could you help with merging these latest changes from Lincomatic. Should this PR be targeting stable? The version numbers are out of sync hence the need to release this under V8.2.3

@KipK could you advise what build flags features we can now disable since these features are handled in UI V2 e.g energy countes, limits etc

@KipK
Copy link
Collaborator

KipK commented Apr 5, 2023

I'm not home for few days , but needs something like PP_AUTOAMPACITY ( as before ) for eu builds and BOOTLOCK for all builds ( needs wifi fw > 4.1.7 )

@lincomatic
Copy link
Member

I cannot change the platformio.ini to fit users' specific needs. Sorry. OpenEVSE needs to use their own platformio.ini

@KipK
Copy link
Collaborator

KipK commented Apr 5, 2023

That's already the case on openEvse git. Those flags should be added there.

@jeremypoulter
Copy link
Collaborator

@glynhudson Looks good to me, both repos now use master as the main/stable branch now. This means GitHub tracks the differences between the two repos better

@KipK
Copy link
Collaborator

KipK commented Apr 5, 2023

@glynhudson , I don't have it under my eyes now but the flags we can disable are the one for limits and timers. I would keep energy meter even if handled by ESP32 now and remove it later ( needs to keep the amp sampling but remove the counter part ) .
I think RAPI_WF can be disabled too and perhaps some other older stuff.

@KipK
Copy link
Collaborator

KipK commented Apr 9, 2023

@glynhudson
so here are my compile flags here :
Is rapi_wf really used ? It's supposed to enable AP mode when pressing the front button, not sure this is really safe as default ^^

build_flags =
-D OEV6
-D RELAY_PWM
-D SHOW_DISABLED_TESTS
-D AMMETER
-D RAPI
-D RAPI_SERIAL
#-D RAPI_WF
-D RAPI_BTN
#-D TIME_LIMIT
#-D CHARGE_LIMIT
-D MENNEKES_LOCK ( not sure it has sense to enable this by default ? )
-D DELAYTIMER
-D RTC (
-D BOOTLOCK

And no change for the emonevse but only need one now, no threephase needed:


[env:emonevse]
extends = env:openevse
build_src_flags=
  ${common.eu_build_flags}
  -D PP_AUTO_AMPACITY
  -D 'VERSION="${common.version}.T2"'

BOOTLOCK enabled will need to mention this firmware needs next release wifi fw version ( 4.1.7 won't unlock the evse )

@KipK KipK mentioned this pull request Apr 11, 2023
@KipK
Copy link
Collaborator

KipK commented Apr 11, 2023

I've remade the PR with solved conflicts #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants