-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge latest changes from Lincomatic V8.2.1 > V8.2.3 #18
Conversation
If Real-Time Clock isn't set, and if we're not setting via the wifi module then the YEAR_MIN should now be a bit more recent to save button pushes. Perhaps YEAR_MAX for the pushbutton menu interface should be more than 10 years later? What's the expected lifespan of this system before we'd expect firmware updates to be applied?
RTC setting improvement via push button menu
@jeremypoulter please could you help with merging these latest changes from Lincomatic. Should this PR be targeting stable? The version numbers are out of sync hence the need to release this under V8.2.3 @KipK could you advise what build flags features we can now disable since these features are handled in UI V2 e.g energy countes, limits etc |
I'm not home for few days , but needs something like PP_AUTOAMPACITY ( as before ) for eu builds and BOOTLOCK for all builds ( needs wifi fw > 4.1.7 ) |
I cannot change the platformio.ini to fit users' specific needs. Sorry. OpenEVSE needs to use their own platformio.ini |
That's already the case on openEvse git. Those flags should be added there. |
@glynhudson Looks good to me, both repos now use |
@glynhudson , I don't have it under my eyes now but the flags we can disable are the one for limits and timers. I would keep energy meter even if handled by ESP32 now and remove it later ( needs to keep the amp sampling but remove the counter part ) . |
@glynhudson build_flags = And no change for the emonevse but only need one now, no threephase needed:
BOOTLOCK enabled will need to mention this firmware needs next release wifi fw version ( 4.1.7 won't unlock the evse ) |
I've remade the PR with solved conflicts #19 |
-> used to change current capacity to PP ampacity. now, only change it
if currently higher than PP ampacity
-> GetMaxCurrentCapacity() is limited to PP ampacity in STATE B/C
20230206 SCL
20220408 V8.2.1 SCL