[MIG] account_operating_unit: Migration to 17.0 #670

jdidderen-nsi · 2024-05-29T08:15:46Z

Depends on:

yankinmax · 2024-06-08T06:26:13Z

account_operating_unit/models/account_move.py

@@ -22,16 +22,6 @@ def create(self, vals_list):
                    vals["operating_unit_id"] = move.operating_unit_id.id
        return super().create(vals_list)

-    @api.model


why is is just removed?

It was removed from OC in v16 (odoo/odoo#96134) and it seems that it's not used anymore outside of reports like account.invoice.report

yankinmax · 2024-06-08T06:33:22Z

account_operating_unit/models/account_move.py

+    def _compute_operating_unit(self):
+        for record in self:
+            if record.journal_id.operating_unit_id:
+                record.operating_unit_id = record.journal_id.operating_unit_id.id


you don't need to explicitly assign an id to a many2one record, just record.journal_id.operating_unit_id

Updated. Thanks for the review 👍

yankinmax · 2024-06-08T06:34:09Z

account_operating_unit/report/account_invoice_report.py

@@ -19,10 +19,3 @@ def _select(self):
            ,line.operating_unit_id
        """
        return select_str
-
-    def _group_by(self):


why is it just removed?

It was removed from OC in v16 (odoo/odoo#96134) and it seems that it's not used anymore outside of reports like account.invoice.report

yankinmax · 2024-06-08T06:37:23Z

account_operating_unit/views/account_move_view.xml

            <field name="line_ids" position="attributes">
-                <attribute name="context">
+                <attribute name="context" operation="update">


operation="update" will be only applied if you have a dependency on base_view_inheritance_extension I suppose, so probably you want to overwrite the original context like it was before

Yes it's exactly that

yankinmax · 2024-06-08T06:38:58Z

As soon as #667 and #669 is merged, everything should be good to go for this one.

why don't simply add tets-requirements.txt file including dependencies references?
just name that commit with prefix DON'T MERGE

jdidderen-nsi · 2024-06-11T08:03:37Z

As soon as #667 and #669 is merged, everything should be good to go for this one.

why don't simply add tets-requirements.txt file including dependencies references? just name that commit with prefix DON'T MERGE

Thanks for the tip :)

Camille0907

Migration technically LGTM

jdidderen-nsi · 2024-06-24T09:38:48Z

account_operating_unit/tests/test_payment_operating_unit.py

@@ -76,7 +76,7 @@ def test_payment_from_two_invoices(self):
        for payment in payments:
            # Validate that inter OU balance move lines are created
            self.assertEqual(len(payment.move_id.line_ids), 2)
-            self.assertAlmostEqual(payment.amount, 115000)
+            self.assertEqual(payment.amount, invoices[0].amount_total)


I don't think so. Since the decimal precision of the amount field is based on the currency, we should not have any difference between the amount of the invoice and the amount of the payment.

jdidderen-nsi · 2024-06-24T09:29:31Z

account_operating_unit/models/account_move.py

            if amls:
-                move.with_context(wip=False).write(
+                move.with_context(check_move_validity=True).write(


It's a key added in Odoo Community a few version ago (https://github.com/odoo/odoo/blob/96223d322c0f59b35ccda01c82e99a1ac6e2fe0c/addons/account/models/account_move.py#L1890).
The purpose is to avoid the check on the balance.

Alright; thank you :)

yankinmax · 2024-07-08T18:37:13Z

@jdidderen-nsi can you please remove dependency commit and rebase?
operating_unit is merged:

[MIG] operating_unit: Migration to 17.0 #667

jdidderen-nsi · 2024-07-09T14:45:59Z

@yankinmax And it's rebased 👍

hbrunn · 2024-07-18T09:24:27Z

I was curious how you solved adding the operating unit to the analytic distribution widget, as I mentioned in the v16 migration, but it seems you didn't, correct? In my opinion this needs to be done for the migration to be complete

jdidderen-nsi · 2024-07-18T09:26:46Z

@hbrunn It was solved directly in the analytic_operating_unit module - #669

hbrunn · 2024-07-18T09:34:43Z

ah nice, thanks. That would then also be a good solution for v16, will backport that eventually

hbrunn

please also cherry pick #685 so that we have feature parity

hbrunn · 2024-07-18T16:36:54Z

please also add d328870 for higher test coverage

yankinmax · 2024-07-19T11:41:21Z

@jdidderen-nsi can you pls apply @hbrunn last suggestions?

…rpart base line This commit adds the operating unit to the cash basis counterpart base line when cash basis accounting is enabled.

jdidderen-nsi · 2024-08-02T10:23:13Z

please also cherry pick #685 so that we have feature parity

please also add d328870 for higher test coverage

@jdidderen-nsi can you pls apply @hbrunn last suggestions?

@hbrunn @yankinmax And it's done 👍

OCA-git-bot · 2024-08-02T10:53:41Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

hbrunn · 2024-08-02T11:35:08Z

/ocabot merge nobump

OCA-git-bot · 2024-08-02T11:35:15Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-670-by-hbrunn-bump-nobump, awaiting test results.

Signed-off-by hbrunn

OCA-git-bot · 2024-08-02T11:42:38Z

@hbrunn your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-670-by-hbrunn-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

AaronHForgeFlow · 2024-08-02T12:12:35Z

Issue with pre-commit on build, trying it again

/ocabot merge nobump

OCA-git-bot · 2024-08-02T12:12:43Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-670-by-AaronHForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot · 2024-08-02T12:18:01Z

Congratulations, your PR was merged at 3583849. Thanks a lot for contributing to OCA. ❤️

jdidderen-nsi force-pushed the 17.0-mig-account_operating_unit branch 3 times, most recently from 10bad65 to 981c6b1 Compare May 31, 2024 17:38

yankinmax reviewed Jun 8, 2024

View reviewed changes

jdidderen-nsi force-pushed the 17.0-mig-account_operating_unit branch from f48771c to a9cc4f5 Compare June 11, 2024 07:28

jdidderen-nsi force-pushed the 17.0-mig-account_operating_unit branch from a9cc4f5 to ba21f64 Compare June 11, 2024 08:04

yankinmax approved these changes Jun 11, 2024

View reviewed changes

jdidderen-nsi mentioned this pull request Jun 11, 2024

[MIG] sale_operating_unit: Migration to 17.0 #672

Merged

4 tasks

jdidderen-nsi force-pushed the 17.0-mig-account_operating_unit branch from ba21f64 to 95d72a4 Compare June 11, 2024 08:50

This was referenced Jun 11, 2024

[MIG] purchase_operating_unit: Migration to 17.0 #674

Merged

[MIG] purchase_stock_operating_unit: Migration to 17.0 #675

Open

[MIG] sale_stock_operating_unit: Migration to 17.0 #676

Merged

Camille0907 approved these changes Jun 17, 2024

View reviewed changes

OCA-git-bot added the approved label Jun 17, 2024

This was referenced Jun 18, 2024

[17.0][MIG] account_financial_report_operating_unit : Migration to 17.0 #686

Merged

[17.0][MIG] contract_operating_unit: Migration to 17.0 tranthanhtrai/operating-unit#4

Open

[17.0][MIG] contract_operating_unit: Migration to 17.0 #688

Merged

sudhir-serpentcs and others added 7 commits July 9, 2024 16:45

[ADD] Added Account Operating Unit module for v9.

c55929f

[FIX] various fixes to ensure that unit tests pass

5a1060b

[IMP] changed Eficent copyright

8b04d73

[IMP] : Migrated the code to version 9

584b014

[IMP] Migrated and tested account_ou module to v9.

da9092c

[FIX] travis errors

781116d

[FIX] remove period_id

bfc1c87

jdidderen-nsi added 2 commits July 9, 2024 16:45

[IMP] account_operating_unit: pre-commit execution

1720907

[MIG] account_operating_unit: Migration to 17.0

cd6a0d2

jdidderen-nsi force-pushed the 17.0-mig-account_operating_unit branch from 95d72a4 to cd6a0d2 Compare July 9, 2024 14:45

hbrunn approved these changes Jul 18, 2024

View reviewed changes

alan196 and others added 2 commits August 2, 2024 12:02

[FIX] account_operating_unit: add operating unit to cash basis counte…

8b47922

…rpart base line This commit adds the operating unit to the cash basis counterpart base line when cash basis accounting is enabled.

[ADD] account_operating_unit: increase test coverage

3b1ee97

OCA-git-bot added the ready to merge label Aug 2, 2024

OCA-git-bot added a commit that referenced this pull request Aug 2, 2024

Merge PR #670 into 17.0

3d98a4f

Signed-off-by hbrunn

OCA-git-bot added the bot is merging ⏳ label Aug 2, 2024

OCA-git-bot removed the bot is merging ⏳ label Aug 2, 2024

OCA-git-bot added the bot is merging ⏳ label Aug 2, 2024

AaronHForgeFlow approved these changes Aug 2, 2024

View reviewed changes

OCA-git-bot merged commit 3381cb8 into OCA:17.0 Aug 2, 2024
5 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Aug 2, 2024

yankinmax mentioned this pull request Aug 5, 2024

[17.0][MIG] account_operating_unit_access_all : Migration to 17.0 #679

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] account_operating_unit: Migration to 17.0 #670

[MIG] account_operating_unit: Migration to 17.0 #670

jdidderen-nsi commented May 29, 2024 •

edited by gurneyalex

Loading

yankinmax Jun 8, 2024

jdidderen-nsi Jun 11, 2024

yankinmax Jun 8, 2024

jdidderen-nsi Jun 11, 2024

yankinmax Jun 8, 2024

jdidderen-nsi Jun 11, 2024

yankinmax Jun 8, 2024

jdidderen-nsi Jun 11, 2024

yankinmax commented Jun 8, 2024

jdidderen-nsi commented Jun 11, 2024

Camille0907 left a comment

This comment was marked as resolved.

jdidderen-nsi Jun 24, 2024

This comment was marked as resolved.

jdidderen-nsi Jun 24, 2024

Camille0907 Jun 28, 2024

yankinmax commented Jul 8, 2024 •

edited by gurneyalex

Loading

jdidderen-nsi commented Jul 9, 2024

hbrunn commented Jul 18, 2024

jdidderen-nsi commented Jul 18, 2024

hbrunn commented Jul 18, 2024

hbrunn left a comment

hbrunn commented Jul 18, 2024

yankinmax commented Jul 19, 2024

jdidderen-nsi commented Aug 2, 2024

OCA-git-bot commented Aug 2, 2024

hbrunn commented Aug 2, 2024

OCA-git-bot commented Aug 2, 2024

OCA-git-bot commented Aug 2, 2024

AaronHForgeFlow commented Aug 2, 2024

OCA-git-bot commented Aug 2, 2024

OCA-git-bot commented Aug 2, 2024

[MIG] account_operating_unit: Migration to 17.0 #670

[MIG] account_operating_unit: Migration to 17.0 #670

Conversation

jdidderen-nsi commented May 29, 2024 • edited by gurneyalex Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yankinmax commented Jun 8, 2024

jdidderen-nsi commented Jun 11, 2024

Camille0907 left a comment

Choose a reason for hiding this comment

This comment was marked as resolved.

Choose a reason for hiding this comment

This comment was marked as resolved.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yankinmax commented Jul 8, 2024 • edited by gurneyalex Loading

jdidderen-nsi commented Jul 9, 2024

hbrunn commented Jul 18, 2024

jdidderen-nsi commented Jul 18, 2024

hbrunn commented Jul 18, 2024

hbrunn left a comment

Choose a reason for hiding this comment

hbrunn commented Jul 18, 2024

yankinmax commented Jul 19, 2024

jdidderen-nsi commented Aug 2, 2024

OCA-git-bot commented Aug 2, 2024

hbrunn commented Aug 2, 2024

OCA-git-bot commented Aug 2, 2024

OCA-git-bot commented Aug 2, 2024

AaronHForgeFlow commented Aug 2, 2024

OCA-git-bot commented Aug 2, 2024

OCA-git-bot commented Aug 2, 2024

jdidderen-nsi commented May 29, 2024 •

edited by gurneyalex

Loading

yankinmax commented Jul 8, 2024 •

edited by gurneyalex

Loading