Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] account_operating_unit #656

Merged
merged 108 commits into from
Jul 30, 2024

Conversation

hbrunn
Copy link
Member

@hbrunn hbrunn commented Mar 14, 2024

TODO

  • patch the analytic distribution widget to inject the operating unit into the analytic account domain
  • add tests for account.bank.statement.line

The module is already perfectly functional, but I don't consider the migration to be properly done without this

sudhir-serpentcs and others added 30 commits March 14, 2024 16:17
…f setting an inter-OU accounts triggers from other modules when creating companies
* Add management of payments using operating units
* Trial Balance by operating units
* Improve tests
weblate and others added 2 commits March 14, 2024 16:17
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: operating-unit-15.0/operating-unit-15.0-account_operating_unit
Translate-URL: https://translation.odoo-community.org/projects/operating-unit-15-0/operating-unit-15-0-account_operating_unit/
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work @hbrunn I think the module works ok. Only pending the 2 items you mentioned. Can you consider to incluide this? #658

Copy link
Sponsor

@houssine78 houssine78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AaronHForgeFlow
Copy link
Contributor

To be also included: #685 Thanks

@hbrunn
Copy link
Member Author

hbrunn commented Jul 8, 2024

note that I won't be working on this any time soon, so whoever has a stake in this migration, please implement the missing points above and cherry pick the commits mentioned

hbrunn and others added 5 commits July 18, 2024 17:57
with different operating units.

That was possible in old versions <v12 but it was removed for unknown
reason.

In general, reconciling a bank journal entry with an invoice
will require Inter OU balancing entries, as long one OU is paying
the balance for the other.
…rpart base line

This commit adds the operating unit to the cash basis counterpart base line
when cash basis accounting is enabled.
@hbrunn hbrunn force-pushed the 16.0-mig-account_operating_unit branch from 5579a49 to f0c0e9c Compare July 18, 2024 15:57
@hbrunn
Copy link
Member Author

hbrunn commented Jul 18, 2024

@AaronHForgeFlow picked the commits you requested and added the patch for the widget

@AaronHForgeFlow
Copy link
Contributor

@hbrunn Thank you! I will do a functional review.

@hbrunn
Copy link
Member Author

hbrunn commented Jul 26, 2024

/ocabot migration account_operating_unit

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jul 26, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 26, 2024
10 tasks
@hbrunn hbrunn mentioned this pull request Jul 26, 2024
1 task
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review, it works as expected. Thanks

@AaronHForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-656-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 83f8a6e into OCA:16.0 Jul 30, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7b751c5. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.