Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdftag: init at 1.0.4 #45666

Merged
merged 1 commit into from
Sep 11, 2018
Merged

pdftag: init at 1.0.4 #45666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions pkgs/tools/graphics/pdftag/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
{ stdenv, fetchFromGitHub, pkgconfig, meson, vala, ninja
, gtk3, poppler, wrapGAppsHook }:

stdenv.mkDerivation rec {
pname = "pdftag";
name = "${pname}-${version}";
version = "1.0.4";

src = fetchFromGitHub {
owner = "arrufat";
repo = pname;
rev = version;
sha256 = "17zk42h0n33b4p8fqlq2riqwcdi8y9m5n0ccydnk6a4x8rli97b3";
};

nativeBuildInputs = [ pkgconfig meson ninja wrapGAppsHook ];
buildInputs = [ gtk3 poppler vala ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, vala should have gone to nativeBuildInputs as well.

Copy link
Contributor Author

@leenaars leenaars Sep 13, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtojnar: Update with that + 1.0.5: #46633 as a new pull request as this one is closed.


patchPhase = ''substituteInPlace meson.build \
--replace "install_dir: '/usr" "install_dir: '$out"
'';

preInstall = "mkdir -p $out/share/licenses/${pname}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think installing licenses is Debianism. Maybe asking upstream about disabling this might be even more important than changing the path.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtojnar: I filed an issue upstream. Note that in some cases the license text has to be distributed alongside the rest as part of the license itself. Installing it in $prefix seems a sane way to go.


meta = with stdenv.lib; {
description = "Edit metadata found in PDFs";
license = licenses.gpl3;
maintainers = with maintainers; [ leenaars ];
platforms = platforms.unix;
};
}
2 changes: 2 additions & 0 deletions pkgs/top-level/all-packages.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4552,6 +4552,8 @@ with pkgs;

pdfcrack = callPackage ../tools/security/pdfcrack { };

pdftag = callPackage ../tools/graphics/pdftag { };

pdf2svg = callPackage ../tools/graphics/pdf2svg { };

fmodex = callPackage ../games/zandronum/fmod.nix { };
Expand Down