-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pdftag: init at 1.0.4 #45666
pdftag: init at 1.0.4 #45666
Conversation
sha256 = "17zk42h0n33b4p8fqlq2riqwcdi8y9m5n0ccydnk6a4x8rli97b3"; | ||
}; | ||
|
||
nativeBuildInputs = [ pkgconfig meson ninja gtk3 poppler wrapGAppsHook ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gtk3
and poppler
should go to buildInputs
, since they need to match the user’s architecture.
}; | ||
|
||
nativeBuildInputs = [ pkgconfig meson ninja gtk3 poppler wrapGAppsHook ]; | ||
buildInputs = [ vala ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vala
on the other hand needs to run on the builder thus it should go to nativeBuildInputs
.
buildInputs = [ vala ]; | ||
|
||
patchPhase = ''substituteInPlace meson.build \ | ||
--replace "install_dir: '/usr" "install_dir: '$out" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you open a bug upstream about this and add a comment linking it here?
--replace "install_dir: '/usr" "install_dir: '$out" | ||
''; | ||
|
||
preInstall = "mkdir -p $out/share/licenses/${pname}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think installing licenses is Debianism. Maybe asking upstream about disabling this might be even more important than changing the path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jtojnar: I filed an issue upstream. Note that in some cases the license text has to be distributed alongside the rest as part of the license itself. Installing it in $prefix seems a sane way to go.
b455c2a
to
0b2f68a
Compare
@GrahamcOfBorg build pdftag |
Success on x86_64-linux (full log) Attempted: pdftag Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: pdftag Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: pdftag Partial log (click to expand)
|
When I install this with
Not sure if it is a bug in this package, or just a defective setup on my system. |
Looks like |
a0cfea6
to
6244791
Compare
0b2f68a
to
2bd0eb0
Compare
Icon themes like Adwaita should not be added to most packages, instead they should be installed by the user. |
Just tried it, works for me now. If you remove Adwaita this should be ready. |
@xeji: Okay, removed Adwaita. |
@GrahamcOfBorg build pdftag |
Success on aarch64-linux (full log) Attempted: pdftag Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: pdftag Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: pdftag Partial log (click to expand)
|
I've fixed the issue upstream, please let me know if there's anything else I should do. |
@arrufat: Thanks a lot for your kind response and understanding! Note that you seem to have made a small change to the semantics of the release tag, you now include the letter v before the number... (previous ones were 1.0.3, 1.0.2, 1.0.1, now you have v1.0.5). Automatic scripts cannot update such changes, so it would be good to be consistent with future releases... |
}; | ||
|
||
nativeBuildInputs = [ pkgconfig meson ninja wrapGAppsHook ]; | ||
buildInputs = [ gtk3 poppler vala ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, vala
should have gone to nativeBuildInputs
as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(note that I'm personally in favor of just numbers, as this is easier for packagers) |
Motivation for this change
User friendly tool for editing metadata was still missing.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)