maintainers: add ofek

[ofek]

Motivation for this change

#163088 (comment)

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[Artturin]

Please read
https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md
and
https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#contributing-contributing

[ofek]

Thanks, fixed!

[Artturin]

the default.nix file should be called from pkgs/top-level/python-packages.nix otherwise it cannot be used

[ofek]

Addressed, thank you!

[Artturin]

a entry for ofek has to be added to ./maintainers/maintainer-list.nix
https://nixos.org/manual/nixpkgs/stable/#var-meta-maintainers
the maintainers: add ofek commit should be before the init commit

and also please fixup the commits where feedback is addressed so once the pr is merged the history will be clean :)

[Artturin]

nix-build . -A python3Packages.hatchling

build fails with

ERROR: Could not find a version that satisfies the requirement tomli~=2.0.0; python_version > "3" (from hatchling) (from versions: none)
ERROR: No matching distribution found for tomli~=2.0.0; python_version > "3"

sadly the tomli update pr hasn't been merged and it also will go in to staging which will take some time to reach the master branch #157735

i will test the builds and if they succeed then merge

so we can either leave this unmerged and then i merge this once the tomli pr is in master or i merge this in to staging

BTW afaik the hatchling does not need to be in nixpkgs for poetry2nix to be able to use it though since hatchling is not poetry, poetry2nix will need to add support for it

Thank you for your patience.

[ofek]

I reordered the commits as requested and relaxed the dependency constraints. Can you please try building again?

[SuperSandro2000]

Suggested change

	# All runtime dependencies

[SuperSandro2000]

Why? The project has tests https://github.com/ofek/hatch/tree/master/tests and missing pythonImportsCheck.

[mweinelt]

Because the tests try to pull at least one library from the internet.

running install tests
<<<<< Copying backend >>>>>
<<<<< Building backend >>>>>
* Creating virtualenv isolated environment...
* Getting dependencies for wheel...
* Installing packages in isolated environment... (editables>=0.2; python_version > "3", importlib-metadata; python_version < "3.8", packaging>=21.3; python_version > "3", packaging~=20.9; python_version < "3", pathspec>=0.9, pluggy>=1.0.0; python_version > "3", pluggy~=0.13; python_version < "3", tomli>=1.2.2; python_version > "3", toml~=0.10.2; python_version < "3")
Ignoring packaging: markers 'python_version < "3"' don't match your environment
Ignoring toml: markers 'python_version < "3"' don't match your environment
Ignoring pluggy: markers 'python_version < "3"' don't match your environment
Ignoring importlib-metadata: markers 'python_version < "3.8"' don't match your environment
WARNING: Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7ffff59be410>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')': /simple/pathspec/
WARNING: Retrying (Retry(total=3, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7ffff59bfe80>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')': /simple/pathspec/
WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7ffff59be0e0>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')': /simple/pathspec/
WARNING: Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7ffff59be110>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')': /simple/pathspec/
WARNING: Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7ffff56fa110>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')': /simple/pathspec/
ERROR: Could not find a version that satisfies the requirement pathspec>=0.9 (from versions: none)
ERROR: No matching distribution found for pathspec>=0.9

[SuperSandro2000]

Ah, it tries to install things into a virtualenv.

[mweinelt]

Already part of python-updates for a datadogpy update. You can pick up maintainership if you want to.
75e47c3 (packaged on saturday) f830574fc9c67b7137a747c94239baf4ad8acf60 (updated now)

[ofek]

@mweinelt Oh yes please, thanks! If it's alright with you can we use fetchPypi instead of fetchFromGitHub? The repo houses 2 projects and I don't want a structure change to disrupt anything.

@Artturin I updated to only add myself to the list of maintainers.

[mweinelt]

As described here the tests currently require the Git repository structure. pypa/hatch#120 (comment)

If that gets fixed and we can run some tests offline that would certainly be appealing.

[ofek]

tests currently require the Git repository structure

Fixed:

• pypa/hatch@165fc1f
• https://pypi.org/project/hatchling/0.20.1/

[mweinelt]

.Migrated to PyPi source in 70ba57a7f48ee1c826ca6fa9c60bf1bac8a0d8d4.