Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.tomli: 1.2.2 -> 2.0.1 #157735

Closed
wants to merge 1 commit into from
Closed

python3Packages.tomli: 1.2.2 -> 2.0.1 #157735

wants to merge 1 commit into from

Conversation

yshym
Copy link
Contributor

@yshym yshym commented Feb 1, 2022 •
edited
Loading

Motivation for this change

Update to the latest version: https://github.com/hukkin/tomli/releases/tag/2.0.0

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@yshym yshym force-pushed the python3Packages.tomli-2.0.0 branch from 715e286 to 30a22f5 Compare February 1, 2022 18:56
fabaff
fabaff reviewed Feb 1, 2022
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will trigger over 1k builds. It should go to staging.

@yshym yshym changed the base branch from master to staging February 1, 2022 19:06
@yshym yshym marked this pull request as ready for review February 1, 2022 19:27
@Artturin
Copy link
Member

Artturin commented Mar 7, 2022

https://github.com/hukkin/tomli/releases/tag/2.0.1 is out

@Artturin Artturin force-pushed the python3Packages.tomli-2.0.0 branch from 3eafcbc to 31a1e24 Compare March 7, 2022 05:36
@Artturin Artturin changed the title python3Packages.tomli: 1.2.2 -> 2.0.0 python3Packages.tomli: 1.2.2 -> 2.0.1 Mar 7, 2022
@Artturin Artturin mentioned this pull request Mar 7, 2022
Merged
13 tasks
@mweinelt
Copy link
Member

mweinelt commented Mar 7, 2022

Superseded by 365a4c1 in #162538.

@mweinelt mweinelt closed this Mar 7, 2022
@yshym yshym deleted the python3Packages.tomli-2.0.0 branch March 7, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@veehaitch veehaitch Awaiting requested review from veehaitch

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yshym @Artturin @mweinelt @fabaff