Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in sampling a kernel with mz-reset-mz pattern (overwriting sample_result register) #997

Merged
merged 2 commits into from
Dec 2, 2023
Merged

Fix bug in sampling a kernel with mz-reset-mz pattern (overwriting sample_result register) #997

merged 2 commits into from
Dec 2, 2023

Conversation

amccaskey
Copy link
Collaborator

Fix #980

@amccaskey
Fix bug in sampling a kernel with mz-reset-mz pattern (overwriting sa…
3828116 
…mple_result register)

Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 2, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@amccaskey
Copy link
Collaborator Author

amccaskey commented Dec 2, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@bmhowe23 bmhowe23 mentioned this pull request Dec 2, 2023
Merged
bmhowe23
bmhowe23 approved these changes Dec 2, 2023
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Alex👍

runtime/common/MeasureCounts.cpp Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Dec 2, 2023
@cuda-quantum-bot
Docs preview for PR #997.
f07106e
@amccaskey
apply pr review suggestion
87e7367 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey amccaskey enabled auto-merge (squash) December 2, 2023 17:35
@amccaskey
Copy link
Collaborator Author

amccaskey commented Dec 2, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@amccaskey amccaskey merged commit 4bf17d3 into NVIDIA:main Dec 2, 2023
104 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2023
@bettinaheim bettinaheim added the bug fix To be listed under Bug Fixes in the release notes label Jan 22, 2024
@bettinaheim bettinaheim added this to the release 0.6.0 milestone Jan 22, 2024
@amccaskey amccaskey deleted the fix980 branch February 29, 2024 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bmhowe23 bmhowe23 bmhowe23 approved these changes

@boschmitt boschmitt Awaiting requested review from boschmitt

Assignees
No one assigned
Labels
bug fix To be listed under Bug Fixes in the release notes
Projects
None yet
Milestone
release 0.6.0
Development

Successfully merging this pull request may close these issues.

Semantics of measurement and cudaq::sample
3 participants
@amccaskey @bmhowe23 @bettinaheim