Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ghost qubit bug #981 #998

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Fix ghost qubit bug #981 #998

merged 3 commits into from
Dec 5, 2023

Conversation

amccaskey
Copy link
Collaborator

@amccaskey amccaskey commented Dec 2, 2023 •
edited
Loading

Fix #981

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 2, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@amccaskey
Copy link
Collaborator Author

amccaskey commented Dec 2, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

bmhowe23
bmhowe23 reviewed Dec 2, 2023
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have a slight reservation about the issue that this PR is attempting to resolve (per this comment), but am ultimately willing to go with whatever the team decides.

That reservation is minor because this change does seem make the behavior of the __global__ register consistent between library mode and emulation mode, and that aspect is - no doubt - a "good thing" ™️.

unittests/integration/measure_reset_tester.cpp Show resolved Hide resolved
unittests/integration/measure_reset_tester.cpp Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Dec 2, 2023
@cuda-quantum-bot
Docs preview for PR #998.
f59f710
@amccaskey
Copy link
Collaborator Author

amccaskey commented Dec 2, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@bmhowe23 bmhowe23 mentioned this pull request Dec 2, 2023
Open
3 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Dec 2, 2023
@cuda-quantum-bot
Docs preview for PR #998.
b66674b
@amccaskey
Fix ghost qubit bug NVIDIA#981
af39c90 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
apply pr review comment
ea300e4 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
Copy link
Collaborator Author

amccaskey commented Dec 4, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Dec 4, 2023
@cuda-quantum-bot
Docs preview for PR #998.
7bec309
@amccaskey
Copy link
Collaborator Author

I still have a slight reservation about the issue that this PR is attempting to resolve (per this comment), but am ultimately willing to go with whatever the team decides.

That reservation is minor because this change does seem make the behavior of the __global__ register consistent between library mode and emulation mode, and that aspect is - no doubt - a "good thing" ™️.

This PR fixes the bug. We'll figure out as a team how to handle the broader discussion you referenced and that work will need to be part of a separate PR. No reason to hold up this bug fix.

bmhowe23
bmhowe23 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@amccaskey
Copy link
Collaborator Author

amccaskey commented Dec 5, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@amccaskey amccaskey enabled auto-merge (squash) December 5, 2023 14:35
@amccaskey amccaskey merged commit 00875c5 into NVIDIA:main Dec 5, 2023
108 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
@bettinaheim bettinaheim added the bug fix To be listed under Bug Fixes in the release notes label Jan 22, 2024
@bettinaheim bettinaheim added this to the release 0.6.0 milestone Jan 22, 2024
@amccaskey amccaskey deleted the fix981 branch February 29, 2024 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bmhowe23 bmhowe23 bmhowe23 approved these changes

@boschmitt boschmitt Awaiting requested review from boschmitt

Assignees
No one assigned
Labels
bug fix To be listed under Bug Fixes in the release notes
Projects
None yet
Milestone
release 0.6.0
Development

Successfully merging this pull request may close these issues.

Ghost qubit in library mode
3 participants
@amccaskey @bmhowe23 @bettinaheim