Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cuquantum to 24.03 and cutensor to 2.0 #1524

Merged
merged 8 commits into from
May 8, 2024

Conversation

1tnguyen
Copy link
Collaborator

Description

Some updates according to the release notes:

  • cutensornetStateApplyTensor -> cutensornetStateApplyTensorOperator
    (introducing the latter, deprecating the former)

  • Use the new cutensornetStateApplyControlledTensorOperator, which supports multi-controlled single-target gates

    • Add special handling for cSWAP, which is the only two-target gate defined in NVQIR runtime.

    • Remove the need for manual decomposition for MPS.

  • Update version info in Dockerfile/build script/etc. as necessary.

Tested by: running tensornet and tensornet-mps unit tests.

    https://docs.nvidia.com/cuda/cuquantum/latest/cutensornet/release_notes.html#cutensornet-v2-4-0

    -  cutensornetStateApplyTensor -> cutensornetStateApplyTensorOperator
       (introducing the latter, deprecating the former)

    - Use the new cutensornetStateApplyControlledTensorOperator:
      multi-controlled single-target gates

        + Add special handling for cSWAP, which is the only two-target gate
          defined in NVQIR runtime.

        + Remove the need for manual decomposition for MPS.

    - Update version info as necessary.

    Tested by: running tensornet and tensornet-mps unit tests.
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 17, 2024
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended for 0.7.1? In any case, we should probably wait for the additional test in #1493 before merging.
Also, will this affect NVQC compatibility? Based on the changeset alone, it doesn't seem like it to me.

@1tnguyen
Copy link
Collaborator Author

Is this intended for 0.7.1? In any case, we should probably wait for the additional test in #1493 before merging. Also, will this affect NVQC compatibility? Based on the changeset alone, it doesn't seem like it to me.

No, it's intended for 0.8 and should only be merged after #1493 and 0.7.1 release.

@schweitzpgi schweitzpgi added this to the release 0.8.0 milestone Apr 22, 2024
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 30, 2024
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but still some residual failures.

Copy link

github-actions bot commented May 6, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request May 6, 2024
Copy link

github-actions bot commented May 7, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Copy link

github-actions bot commented May 8, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request May 8, 2024
@1tnguyen 1tnguyen merged commit a726804 into NVIDIA:main May 8, 2024
125 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2024
@bettinaheim bettinaheim added release notes Changes need to be captured in the release notes breaking change Change breaks backwards compatibility labels Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change Change breaks backwards compatibility release notes Changes need to be captured in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants