-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump cuquantum
to 24.03 and cutensor
to 2.0
#1524
Conversation
https://docs.nvidia.com/cuda/cuquantum/latest/cutensornet/release_notes.html#cutensornet-v2-4-0 - cutensornetStateApplyTensor -> cutensornetStateApplyTensorOperator (introducing the latter, deprecating the former) - Use the new cutensornetStateApplyControlledTensorOperator: multi-controlled single-target gates + Add special handling for cSWAP, which is the only two-target gate defined in NVQIR runtime. + Remove the need for manual decomposition for MPS. - Update version info as necessary. Tested by: running tensornet and tensornet-mps unit tests.
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intended for 0.7.1? In any case, we should probably wait for the additional test in #1493 before merging.
Also, will this affect NVQC compatibility? Based on the changeset alone, it doesn't seem like it to me.
No, it's intended for 0.8 and should only be merged after #1493 and 0.7.1 release. |
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, but still some residual failures.
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Description
Some updates according to the release notes:
cutensornetStateApplyTensor
->cutensornetStateApplyTensorOperator
(introducing the latter, deprecating the former)
Use the new
cutensornetStateApplyControlledTensorOperator
, which supports multi-controlled single-target gatesAdd special handling for cSWAP, which is the only two-target gate defined in NVQIR runtime.
Remove the need for manual decomposition for MPS.
Update version info in Dockerfile/build script/etc. as necessary.
Tested by: running
tensornet
andtensornet-mps
unit tests.