Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Python wheel installation issues (multiple subtlety linked items) #1493

Merged
merged 41 commits into from
May 6, 2024
Merged

Fix Python wheel installation issues (multiple subtlety linked items) #1493

merged 41 commits into from
May 6, 2024

Conversation

bmhowe23
Copy link
Collaborator

@bmhowe23 bmhowe23 commented Apr 10, 2024 •
edited
Loading

Description

This PR contains a variety of fixes that all stemmed from the fact that the instructions provided on https://pypi.org/project/cuda-quantum/0.7.0/ (which originate from python/README.md) were no longer working after new versions of transitive dependencies were added to conda-forge, and that meant that the tensornet backend could no longer be used. The main point of this PR is to get the instructions in a working state again.

Details

The full list of changes in this PR are:

  • Place conda's library path before system library path in case multiple CUDA versions are installed on the host.
  • Pin the cuquantum conda-forge version (this was the original solution for the PR, but there was a desire to remove this conda dependency and simply rely on the Python PIP package dependency that was already pinned).
  • Remove cuquantum from the Python installation instructions. (e1e84ae)
    • Since we're removing this from the install instructions, I had to create tools/cudaq-qpud/cudaq-qpud.py as a launch script.
    • Updated docs for the new launch script in 2cd4f29.
  • Fix a Python library initialization bug that was preventing the pre-existing library detection code from working. (91c9cbf)
  • Fix a lambda capture bug that was only happening with g++ 11.2.1. (246b132 and 7fb1dff). This bug appears to have been due to a compiler bug w/ g++ 11.2.1 that we hadn't previously encountered.
  • Fix a bug where the sample_async_remote.py example file was accidentally auto-launching cudaq-qpud rather than using the ones provided with the --server option (a18113d)
  • Add a Publishing test to validate the Python wheel instructions every time we push a new PR into main

@bmhowe23
Fix Python wheel instructions
9c2d2a2 
* Place conda's library path before system library path in case multiple
  CUDA versions are installed on the host.
* Pin the cuquantum version
@bmhowe23
Another fix but in a new way
3c76c45
@bmhowe23
Revert "Another fix but in a new way"
a931da3 
This reverts commit 3c76c45.
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 10, 2024
@cuda-quantum-bot
Docs preview for PR #1493.
b276f0a
amccaskey
amccaskey reviewed Apr 10, 2024
View reviewed changes
python/README.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 10, 2024
@cuda-quantum-bot
Docs preview for PR #1493.
07eb2ec
@bmhowe23 bmhowe23 changed the title Fix Python wheel README instructions Fix Python wheel README instructions and __init__.py issue Apr 10, 2024
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 10, 2024
@cuda-quantum-bot
Docs preview for PR #1493.
70afada
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 11, 2024
@cuda-quantum-bot
Docs preview for PR #1493.
ad7e2c3
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 11, 2024
@cuda-quantum-bot
Docs preview for PR #1493.
6bc7b85
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 11, 2024
@cuda-quantum-bot
Docs preview for PR #1493.
ecd7c32
@bmhowe23 bmhowe23 added this to the release 0.7.1 milestone Apr 17, 2024
@bmhowe23 bmhowe23 added documentation Improvements or additions to documentation bug fix To be listed under Bug Fixes in the release notes labels Apr 17, 2024
github-actions bot pushed a commit that referenced this pull request Apr 17, 2024
@cuda-quantum-bot
Docs preview for PR #1493.
314fea0
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 18, 2024
@cuda-quantum-bot
Docs preview for PR #1493.
882f1af
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 24, 2024
@cuda-quantum-bot
Docs preview for PR #1493.
6ef94fb
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 26, 2024
@cuda-quantum-bot
Docs preview for PR #1493.
5af4453
@bmhowe23 bmhowe23 mentioned this pull request Apr 26, 2024
Merged
@schweitzpgi
Copy link
Collaborator

Just checking in here. Is this a draft (per the Conda comments) or are you waiting for a review?

@bmhowe23
Copy link
Collaborator Author

Just checking in here. Is this a draft (per the Conda comments) or are you waiting for a review?

This is no longer just a draft. It is ready for review and is the primary PR required for 0.7.1. It needs code owner approval due to the changes to the .github directory. (@bettinaheim)

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 29, 2024
@cuda-quantum-bot
Docs preview for PR #1493.
da1e7ae
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 30, 2024
@cuda-quantum-bot
Docs preview for PR #1493.
c3dd5b8
@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request May 3, 2024
@cuda-quantum-bot
Docs preview for PR #1493.
33fc849
@bettinaheim bettinaheim merged commit 47994fb into NVIDIA:main May 6, 2024
125 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2024
@bmhowe23 bmhowe23 deleted the pr-fix-Python-readme branch May 6, 2024 16:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amccaskey amccaskey amccaskey left review comments

@leofang leofang leofang left review comments

@schweitzpgi schweitzpgi schweitzpgi left review comments

@bettinaheim bettinaheim bettinaheim approved these changes

Assignees
No one assigned
Labels
bug fix To be listed under Bug Fixes in the release notes documentation Improvements or additions to documentation
Projects
None yet
Milestone
release 0.7.1
Development

Successfully merging this pull request may close these issues.
5 participants
@bmhowe23 @schweitzpgi @amccaskey @leofang @bettinaheim