Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for global HELICS_PORT #16

Merged
merged 6 commits into from
Apr 26, 2023
Merged

Conversation

dvaidhyn
Copy link
Collaborator

Add HELICS port numbers for broker, controller, AMRWind and dummy-AMRWind.

Copy link
Collaborator

@paulf81 paulf81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you @dvaidhyn !

# Set up the helics broker
helics_broker -t zmq -f 2 --loglevel="debug" &
helics_broker -f 2 --consoleloglevel=trace --loglevel=debug --local_port=23405 &
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this call back to HELICS_PORT?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I will modify this right away. Thanks!

@misi9170
Copy link
Collaborator

@dvaidhyn @paulf81 I've made a couple of changes to the 05 and 06 examples to get the HELICS_PORT environmental variable copied in to the correct locations; I've both examples 05 and 06 and things seem to be running fine.

I think this is ready for merge.

@misi9170 misi9170 changed the title Develop Update for global HELICS_PORT Apr 26, 2023
@jfrederik-nrel jfrederik-nrel merged commit fac8ed7 into NREL:develop Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants