-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wind up example using FlascDataFrame
#210
Conversation
@aclerc I've merged back the flasc-dataframe target branch and resolved conflicts. Tests pass, and I checked that the examples_smarteole/09_wake_steering_uplift_analysis.ipynb notebook still runs and appears to produce the expected outputs. EDIT: perhaps not---I just ran the notebook again and get an error This remerging may need to happen one more time if we get #211 , which adds some core components to the |
Hi @misi9170 regarding |
Thanks @aclerc, that fixed it. I was using pandas 2.0.2 when I was having the problem, and upgrading to the current 2.2.2 solved the problem (I also had to upgrade pyarrow for compatibility with pandas 2.2.2). pandas 2.0.2 actually satisfies the current FLASC pandas requirement ( Confirming now that the notebook produces the expected 0.6%, -0.2%, 1.4% result. |
Feature or improvement description
Add a simple example of a wind-up uplift and uncertainty calculation
The filtered and northed flasc dataframe is converted to wind-up format using a new
FlascDataFrame
methodIt is probably best to merge PR #199 before merging this PR because I branched from
misi9170:feature/flasc-df
Related issue, if one exists
#195
Test results, if applicable
I have added
test_convert_to_windup_format()
which passes for me locally