Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wind-up example #203

Closed
wants to merge 8 commits into from
Closed

wind-up example #203

wants to merge 8 commits into from

Conversation

aclerc
Copy link

@aclerc aclerc commented Aug 11, 2024

Feature or improvement description
Add a simple example of a wind-up uplift and uncertainty calculation
Add flasc/utilities/wind_up_tools.py as a place for helpful functions to use the wind-up package

Related issue, if one exists

Impacted areas of the software

Additional supporting information
I originally branched from main, hence the extra commits from christiannvaughn to README.
I also noticed a typo in the README so fixed it.
I also edited flasc/data_processing/filtering.py because I was getting an AttributeError from lgd.legendHandles when running the other smarteole example notebooks

Test results, if applicable
I'd be happy to add tests to flasc/utilities/wind_up_tools.py but have not done that yet as I thought a bit of discussion about the design would be good first

@aclerc aclerc changed the base branch from main to develop August 11, 2024 15:40
@aclerc aclerc marked this pull request as draft August 11, 2024 15:41
fix apparent typo
add placeholding values for columns missing from smarteole example
@aclerc aclerc marked this pull request as ready for review August 12, 2024 18:48
@aclerc
Copy link
Author

aclerc commented Sep 6, 2024

This PR can be closed if #210 is preferred

@misi9170
Copy link
Collaborator

misi9170 commented Sep 9, 2024

Thanks @aclerc ! I'll close this one in favor of #210

@misi9170 misi9170 closed this Sep 9, 2024
@aclerc
Copy link
Author

aclerc commented Sep 9, 2024

Thanks @aclerc ! I'll close this one in favor of #210

OK no problem @misi9170 . #210 has conflicts I guess due to being re-based, I assume you or someone in your team will fix those but if you're waiting on me let me know

@misi9170
Copy link
Collaborator

misi9170 commented Sep 9, 2024

@aclerc , we will fix those---I had meant to get to it last week but there are a few complications coming from #211 that we're also working through. We're hoping to get those all dealt with soon.

@aclerc aclerc deleted the wind-up-example branch September 10, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants