Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove requirements.txt and all references to it #68

Closed
wants to merge 1 commit into from

Conversation

egpbos
Copy link
Member

@egpbos egpbos commented May 27, 2020

This includes all CI commands where it was used to only install dependencies, which was an empty list though. Now they all install the package through setup.py.

Fixes #67.

This includes all CI commands where it was used to only install dependencies, which was an empty list though. Now they all install the package through setup.py.
Copy link
Member

@fdiblen fdiblen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @egpbos 🥇
Please merge it after fixing the conflict.

@egpbos
Copy link
Member Author

egpbos commented Dec 1, 2020

I don't have write access, so I cannot fix the conflict on GitHub. Can you give me access? Also, that might help in the future to merge a bit faster, because the conflict was actually created by a later PR, not by this one ;)

@sverhoeven
Copy link
Member

Will continue work in #100

@sverhoeven sverhoeven closed this Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove requirements.txt
3 participants