Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove requirements.txt #67

Closed
egpbos opened this issue May 27, 2020 · 4 comments
Closed

Remove requirements.txt #67

egpbos opened this issue May 27, 2020 · 4 comments
Assignees
@sverhoeven
Labels
enhancement generated-package Related to the generated package, i.e. after running cookiecutter
Milestone
0.3.0

Comments

@egpbos
Copy link
Member

egpbos commented May 27, 2020

We don't need it in the template, see discussion here: NLeSC/guide#156
@egpbos egpbos mentioned this issue May 27, 2020
Closed
@fdiblen fdiblen added this to the 0.3.0 milestone Apr 7, 2021
@fdiblen
Copy link
Member

fdiblen commented Apr 7, 2021

We should review PR #68

@sverhoeven sverhoeven self-assigned this Apr 7, 2021
@sverhoeven
Copy link
Member

Conflict in #68 fixed in #100

@jspaaks jspaaks added the generated-package Related to the generated package, i.e. after running cookiecutter label Apr 14, 2021
@fdiblen fdiblen modified the milestones: Task pool, 0.3.0 Apr 15, 2021
@sverhoeven
Copy link
Member

Fixed in #68 and #100 for generated package. Close it?

@egpbos
Copy link
Member Author

egpbos commented Apr 16, 2021

Yep, thanks!

@egpbos egpbos closed this as completed Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sverhoeven sverhoeven

Labels
enhancement generated-package Related to the generated package, i.e. after running cookiecutter
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

remove requirements.txt and all references to it egpbos/python-template
4 participants
@fdiblen @sverhoeven @jspaaks @egpbos