Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Ensure suspended sessions are not readded to a-c SessionStore #3668

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Ensure suspended sessions are not readded to a-c SessionStore #3668

merged 1 commit into from
Jul 10, 2020

Conversation

bluemarvin
Copy link
Contributor

Fixes #3620

@bluemarvin bluemarvin requested a review from keianhzo July 10, 2020 20:36
@bluemarvin bluemarvin self-assigned this Jul 10, 2020
@bluemarvin bluemarvin added this to the #11 polish milestone Jul 10, 2020
@bluemarvin bluemarvin added the Uplift PR that needs to be uplifted. label Jul 10, 2020
daoshengmu
daoshengmu approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@daoshengmu daoshengmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It looks like it works after this fix.

app/src/common/shared/org/mozilla/vrbrowser/browser/engine/Session.java Show resolved Hide resolved
@bluemarvin bluemarvin merged commit 096c159 into main Jul 10, 2020
@bluemarvin bluemarvin deleted the one-add-notification branch July 10, 2020 23:03
bluemarvin added a commit that referenced this pull request Jul 10, 2020
@bluemarvin
Ensure suspended sessions are not readded to a-c SessionStore (#3668)
45f818a 
Fixes #3620
@bluemarvin bluemarvin mentioned this pull request Jul 10, 2020
Closed
@keianhzo keianhzo mentioned this pull request Jul 13, 2020
Closed
@bluemarvin bluemarvin removed the Uplift PR that needs to be uplifted. label Jul 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MortimerGoro MortimerGoro MortimerGoro approved these changes

@daoshengmu daoshengmu daoshengmu approved these changes

@keianhzo keianhzo Awaiting requested review from keianhzo

Assignees

@bluemarvin bluemarvin

Labels
None yet
Projects
None yet
Milestone
#11 polish
Development

Successfully merging this pull request may close these issues.

The app crashes when switching to normal browsing and back to PB while having all windows opened
3 participants
@bluemarvin @MortimerGoro @daoshengmu