This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Fixes #3620 Improved SessionStore/BrowserStore sync #3660
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluemarvin
reviewed
Jul 9, 2020
Comment on lines
+811
to
+812
| restore(mIsSuspended ? RECREATE_FROM_SUSPEND : CREATE); | ||
|
|
There was a problem hiding this comment.
Can we just use the mIsSuspended flag in the restore function and then we wouldn't need the CREATE, RECREATE, RECREATE_FROM_SUSPENDED flags?
In restore() you could do:
if (!mIsSuspended) {
mSessionChangeListeners.forEach(listener -> listener.onSessionAdded(this));
}
mIsSuspended = false;
There was a problem hiding this comment.
During a recreation the session is already suspended when restored but we could use a flag instead.
|
Closing in favor of #3668 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3620 When switching and suspending before onSessionStateChange has been called, mSession.mSessionState might be still null and we were adding the session to the BrowserStore twice. I have added a parameter to the recreate method to better track the session recreate origin as it can happen in multiple situations and not all the them require adding the session to the BrowserStore.