Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Improve separator line quality and create a reusable style. #1377

Merged
merged 1 commit into from
Jul 9, 2019
Merged

Improve separator line quality and create a reusable style. #1377

merged 1 commit into from
Jul 9, 2019

Conversation

MortimerGoro
Copy link
Contributor

Fixes #959

  • Improve separator line quality
  • Create a reusable style for all line separators

keianhzo
keianhzo approved these changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@keianhzo keianhzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have a Vive to test but code looks good and I see no difference in Oculus.

@philip-lamb philip-lamb self-requested a review July 9, 2019 21:38
philip-lamb
philip-lamb approved these changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@philip-lamb philip-lamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM.

@philip-lamb philip-lamb merged commit a110c6e into master Jul 9, 2019
@bluemarvin
Copy link
Contributor

Build failure looks like automation failure. Re-running build: https://tools.taskcluster.net/groups/CPX86IdsSGuayTSUNKVpag/tasks/CPX86IdsSGuayTSUNKVpag/runs/1

@bluemarvin
Copy link
Contributor

Second build passed.

@philip-lamb philip-lamb deleted the separator_quality branch July 12, 2019 03:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@keianhzo keianhzo keianhzo approved these changes

@philip-lamb philip-lamb philip-lamb approved these changes

@bluemarvin bluemarvin Awaiting requested review from bluemarvin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the visual quality on Vive Focus
4 participants
@MortimerGoro @bluemarvin @keianhzo @philip-lamb