Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: @metamask/eth-sig-util@^5.0.2->^7.0.0 #189

Merged
merged 3 commits into from
Nov 6, 2023
Merged

deps: @metamask/eth-sig-util@^5.0.2->^7.0.0 #189

merged 3 commits into from
Nov 6, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 3, 2023 •
edited
Loading

  • Bump @metamask/eth-sig-util from ^5.0.2 to ^7.0.0

Blocked by

@socket-security
Copy link

socket-security bot commented Oct 3, 2023 •
edited
Loading

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/eth-sig-util 5.1.0...7.0.0 filesystem +5/-0 1 MB metamaskbot

@legobeat legobeat added the dependencies Pull requests that update a dependency file label Oct 3, 2023
@legobeat legobeat mentioned this pull request Oct 3, 2023
Merged
@legobeat legobeat marked this pull request as ready for review October 7, 2023 03:25
@legobeat legobeat requested a review from a team as a code owner October 7, 2023 03:25
@legobeat legobeat force-pushed the deps-eth-sig-util-7 branch 3 times, most recently from f60597f to 6b04133 Compare October 7, 2023 03:41
@legobeat legobeat requested a review from mcmire October 20, 2023 00:37
@legobeat legobeat requested review from a team and kumavis October 20, 2023 01:15
@legobeat legobeat mentioned this pull request Oct 31, 2023
Merged
14 tasks
mikesposito
mikesposito previously approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One note: The PR description mentions updating trezor/ packages, is this intended?

@legobeat
Copy link
Contributor Author

legobeat commented Nov 3, 2023

LGTM!

One note: The PR description mentions updating trezor/ packages, is this intended?

Good catch, these updates were originally in the same branch/R but were broken out at some point and I forgot about that and updating the desc.

@legobeat
Copy link
Contributor Author

legobeat commented Nov 3, 2023

Updated to do a proper dedupe again after rebase on main.

@legobeat legobeat merged commit f1282c7 into MetaMask:main Nov 6, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikesposito mikesposito mikesposito approved these changes

@adonesky1 adonesky1 Awaiting requested review from adonesky1

@danroc danroc Awaiting requested review from danroc

@montelaidev montelaidev Awaiting requested review from montelaidev

@jiexi jiexi Awaiting requested review from jiexi

@darkwing darkwing Awaiting requested review from darkwing

@danjm danjm Awaiting requested review from danjm

@mcmire mcmire Awaiting requested review from mcmire

@kumavis kumavis Awaiting requested review from kumavis

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @mikesposito