Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase minimum Node.js version from 14 to 16 #188

Merged
merged 2 commits into from
Oct 7, 2023
Merged

Increase minimum Node.js version from 14 to 16 #188

merged 2 commits into from
Oct 7, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 3, 2023 •
edited
Loading

  • BREAKING: drop support for Node.js major versions 14-15,17,19
    • ci: run on node 20 instead of 14,19

Blocking

@legobeat legobeat requested a review from a team as a code owner October 3, 2023 03:58
@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/node 14.18.63...16.18.57 None +0/-0 3.52 MB types

@legobeat legobeat mentioned this pull request Oct 3, 2023
Merged
1 task
@legobeat legobeat requested review from a team October 3, 2023 13:00
adonesky1
adonesky1 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legobeat legobeat merged commit d693964 into MetaMask:main Oct 7, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adonesky1 adonesky1 adonesky1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @adonesky1