Better scrolling list controls #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* GlobalFunc is a singleton, creates a mini console at top of screen. * GlobalFunc.getInstance().Deebug(msg) prints msg to debug pane. * Scrolls after 4 lines or so.
* Created a new iHighlightIndex that generally works like iSelectedIndex
did, except that it is not always the same as selectedIndex.
* doSetSelectedIndex() takes a third parameter, if it is explicitly
true, then only the highlighted index changes, if not set to true,
then it will also change the iSelectedIndex as in vanilla.
* SetEntry() uses iHighlightedIndex instead of iSelectedIndex,
thus allowing to highlight other items without iSelectedIndex
changing.
* iSelectedIndex is controlled by keyboard only, or it is set when
the mouse is clicked, but no longer when the mouse is moved.
* Navigation up or down always moves the highlight back to the
selected item, which is at center.
* The mousewheel scroll now uses moveSelectionUp/Down()
so it also always resets the highlight to the center item.
* Saved in CS5.5 in CS4 format and working. Just my local version doesn't actually have structural changes yet, compared to the Mardoxx/skyrimui version. It was a FLA file from an earlier pre- v1.8 Skyrim commit though!
* The build path is set directly to my Skyrim/Data/Interface folder. Otherwise same as skyrimui, but this one is the latest commit from post-v1.8.151.0 Skyrim. * ...it seems to work fine in Skyrim v1.7.7.0.6.
* Using the mousewheel after selecting a topic would scroll through the previously available options. In vanilla Skyrim, the selected topic would be sort of "locked" until the NPC has done talking. Since the mousewheel event now calls moveSelectionUp/Down() for a smoother scrolling, it also called the update function which would redraw the other options (I think *blush*). Now it just checks for the menustate and will not initiate scrolling until menu state is back to TOPIC_LIST_SHOWN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It look like at least some of the improvements made here would also be relevant to other menus. In particular, that thing where the mouse pointer interferes with keyboard controls is really annoying, and e5f0d8d in particular would appear to be applicable to, say, the quest journal too...